Skip to content

Commit 8916850

Browse files
authored
Merge pull request #232 from yarikoptic/bf-pydantic
BF: Fix pydantic validation error for missing started field in AppveyorBuild
2 parents 81a6d99 + 87d1352 commit 8916850

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/tools/daily-status.py

100644100755
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ def as_html(self, build_id: int) -> str:
253253
class AppveyorBuild(BaseModel):
254254
buildId: int
255255
finished: datetime | None
256-
started: datetime
256+
started: datetime | None = None # could have been canceled thus never started
257257
version: str
258258
status: str
259259
jobs: List[AppveyorJob]
@@ -272,7 +272,7 @@ def get_summary(self) -> Counter[Outcome]:
272272
return Counter(j.outcome for j in self.jobs)
273273

274274
def as_html(self) -> str:
275-
s = f'<p>{self.outcome.as_html()} <a href="{self.url}">{self.version}</a> {self.started}</p>\n<ul>\n'
275+
s = f'<p>{self.outcome.as_html()} <a href="{self.url}">{self.version}</a> {self.started or self.status}</p>\n<ul>\n'
276276
for j in self.jobs:
277277
s += "<li>" + j.as_html(self.buildId) + "</li>\n"
278278
return s + "</ul>\n"

0 commit comments

Comments
 (0)