Skip to content

Commit b534ba3

Browse files
authored
Revert quote changes for nmake defines (#19859)
* Revert quote changes for nmake defines * Bump patch * Fix tests
1 parent 4211f5a commit b534ba3

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

conan/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
from conan.internal.model.workspace import Workspace
33
from conan.internal.model.version import Version
44

5-
__version__ = '2.27.0'
5+
__version__ = '2.27.1'
66
conan_version = Version(__version__)

conan/tools/microsoft/nmakedeps.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from conan.tools.env import Environment
66

77

8-
def format_defines(defines):
8+
def format_defines(defines, toolchain=False):
99
def is_hex_or_numeric(s):
1010
try:
1111
# Check for Hexadecimal (base 16)
@@ -22,7 +22,7 @@ def is_hex_or_numeric(s):
2222
macro, value = define.split("=", 1)
2323
if value and not is_hex_or_numeric(value):
2424
# value quotes are escaped
25-
value = f'\\"{value}\\"'
25+
value = f'\\"{value}\\"' if toolchain else f'\"{value}\"'
2626
define = f"{macro}#{value}"
2727
formated_defines.append(f'/D"{define}"')
2828
return formated_defines

conan/tools/microsoft/nmaketoolchain.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def _cl(self):
5858
defines.extend(self.extra_defines)
5959

6060
return (["/nologo"] + self._format_options(bt_flags + rt_flags + cflags + cxxflags) +
61-
format_defines(defines))
61+
format_defines(defines, toolchain=True))
6262

6363
@property
6464
def _link(self):

test/integration/toolchains/microsoft/test_nmakedeps.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ def package_info(self):
4343
# Checking that defines are added to CL
4444
for flag in (
4545
r'/D"TEST_DEFINITION1"', '/D"TEST_DEFINITION2#0"',
46-
r'/D"TEST_DEFINITION3#"', r'/D"TEST_DEFINITION4#\"foo\""',
47-
r'/D"TEST_DEFINITION5#\"__declspec(dllexport)\""',
48-
r'/D"TEST_DEFINITION6#\"foo bar\""',
46+
r'/D"TEST_DEFINITION3#"', '/D"TEST_DEFINITION4#"foo""',
47+
r'/D"TEST_DEFINITION5#"__declspec(dllexport)""',
48+
r'/D"TEST_DEFINITION6#"foo bar""',
4949
r'/D"TEST_DEFINITION7#7"',
5050
r'/D"TEST_WINVER#0x0601"'
5151
):

0 commit comments

Comments
 (0)