START-4 fix coverage paths better, ignore generated files, fix linting

Author: scytacki

.github/workflows/playwright.yml

@@ -43,5 +43,5 @@ jobs:
     - uses: daun/playwright-report-summary@v3
       if: always()
       with:
-        report-file: results.json
+        report-file: playwright/results.json
         report-url: https://models-resources.concord.org/codap-plugin-starter-project/playwright-report/${{ steps.s3-deploy-path.outputs.deployPath }}/

codecov.yml

@@ -21,7 +21,7 @@ import playwright from "eslint-plugin-playwright";
 export default typescriptEslint.config(
   {
     name: "ignore dist and node_modules",
-    ignores: ["dist/", "node_modules/", ".vscode/", "old.*"]
+    ignores: ["dist/", "node_modules/", ".vscode/", "playwright-report/"]
   },
   js.configs.recommended,
   tsConfigs.recommended,

eslint.config.mjs

@@ -20,8 +20,20 @@ const coverageReporter: ReporterDescription = [
          ignore them here. */
       "codap-plugin-starter-project/src/codap/**"
     ],
+    /* Modify the paths of files on which coverage is reported. This is run after
+       the exclude filter, so it does not get any of the codap3 files.
+       The paths returned by the v8 coverage have two issues which at least make them
+       break the html report. They have an extra prefix of the project name so they
+       look like `codap-plugin-starter-project/codap-plugin-starter-project/src`. They
+       have a suffix like `?[random string]` like `App.tsx?c341`. */
+    rewritePath: ({absolutePath}) => {
+      // It isn't clear if this is before or after the exclude rule
+      return (absolutePath as string)
+        .replace("codap-plugin-starter-project/", "")
+        .replace(/\?[0-9a-z]+$/,"");
+    },
     /* Directory in which to write coverage reports */
-    resultDir: path.join(__dirname, "results/e2e-coverage"),
+    resultDir: path.join(__dirname, "playwright", "coverage"),
     /* Configure the reports to generate.
        The value is an array of istanbul reports, with optional configuration attached. */
     reports: [
@@ -50,7 +62,7 @@ const coverageReporter: ReporterDescription = [
 /* We report json in CI so the `daun/playwright-report-summary` action can add a summary of
    the results to a PR comment. */
 const reportJson = !!process.env.CI;
-const jsonReporter: ReporterDescription = ["json", { outputFile: "results.json" }];
+const jsonReporter: ReporterDescription = ["json", { outputFile: path.join("playwright", "results.json") }];
 
 /**
  * See https://playwright.dev/docs/test-configuration.
@@ -68,6 +80,7 @@ export default defineConfig<PlaywrightCoverageOptions>({
   /* Reporter to use. See https://playwright.dev/docs/test-reporters */
   reporter: [
     [ "html" ],
+    [ "list" ],
     ...(collectCoverage ? [coverageReporter] : []),
     ...(reportJson ? [jsonReporter] : []),
   ],

playwright.config.ts

@@ -1,7 +1,7 @@
 import { expect } from "@playwright/test";
 import { test } from "./fixtures";
 
-test("Test app inside of CODAP", async ({page}) => {
+test("App inside of CODAP", async ({page}) => {
   await page.setViewportSize({width: 1400, height: 800});
   await page.goto("https://codap3.concord.org/?mouseSensor&di=https://localhost:8080");
 

playwright/in-codap.spec.ts

@@ -0,0 +1,9 @@
+{
+  "compilerOptions": {
+    "module": "NodeNext",
+    "target": "es2022",
+    "lib": ["es2022"],
+    "types": ["node"]
+  },
+  "include": ["**/*.ts"]
+}