libarchive can't decompress go-dep 0.5.0 tar or zip archives.

[sodre]

Issue:
libarchive is not able to decompress archives with symlinks on Windows. Here are the links to the AppVeyor logs:

• https://ci.appveyor.com/project/conda-forge/staged-recipes/builds/21304030
• https://ci.appveyor.com/project/conda-forge/staged-recipes/builds/21304253

@jakirkham said
Interesting. Yeah the Windows symlink story has been weak historically. Looks like libarchive doesn't really have a solution for that.

That said, we might be able to solve it with this patch, which is being worked on in PR ( libarchive/libarchive#1030 ). Could you please raise an issue about this on the conda-forge libarchive feedstock?

ref: @conda-forge/go-dep-feedstock#6

[mingwandroid]

We've been using this patch for a good while now on AD.

[sodre]

humm.. we are in trouble then. I just looked closer at the appveyor logs and it looks like it installed libarchive 3.3.3 from defaults. Is that still the latest?

[mingwandroid]

I'll try to take a look later or possibly tomorrow.

[sodre]

Thank you. It is not blocking anything for me since we picked up the package from git_url + git_rev when building on Windows and the tar.gz for unix.

[mingwandroid]

It's not quite as bad as you may think. This archive contains deliberately broken symlinks:

lrwxrwxrwx  0 root   root        0 Jul 25 23:33 dep-0.5.0/internal/fs/testdata/symlinks/file-symlink -> ../test.file
lrwxrwxrwx  0 root   root        0 Jul 25 23:33 dep-0.5.0/internal/fs/testdata/symlinks/invalid-symlink -> /non/existing/file
lrwxrwxrwx  0 root   root        0 Jul 25 23:33 dep-0.5.0/internal/fs/testdata/symlinks/windows-file-symlink -> C:/Users/ibrahim/go/src/github.com/golang/dep/internal/fs/testdata/test.file

IMHO libarchive is correct to complain about this, but it needs a way to ignore it too.

[mingwandroid]

Given this is a problem with deliberately broken archives and that you have a workaround, I will likely not look at it immediately.

[sodre]

It is fine with me 👍.

[jakirkham]

Is this still an issue @sodre?