Skip to content

Fixes a bad cast and a new black format warning - #536

Merged
leahsch merged 1 commit into
mainfrom
smartin/git_artifact_bug
Jun 12, 2026
Merged

Fixes a bad cast and a new black format warning#536
leahsch merged 1 commit into
mainfrom
smartin/git_artifact_bug

Conversation

@schuylermartin45

@schuylermartin45 schuylermartin45 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator
  • Fixes a bad cast that incorrectly suppressed a legitimate mypy error. This caused the wrong exception to be thrown when a package failed to be acquired.
  • Also fixes a newer black formatting warning

@schuylermartin45

Copy link
Copy Markdown
Collaborator Author

Normally I'd aim to put in a regression test but I can't think of anything super meaningful here. This was just an incredibly bad cast that should not have been made.

@leahsch
leahsch merged commit 2e1d1b7 into main Jun 12, 2026
15 checks passed
@leahsch
leahsch deleted the smartin/git_artifact_bug branch June 12, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants