Fix detect binary files prefix inversion - #539
Merged
schuylermartin45 merged 3 commits intoJun 24, 2026
Merged
Conversation
Extends the dynamic-linking fixture with detect_binary_files_with_prefix and ignore_prefix_files. The expected V1 output encodes the correct mapping (detect_binary_files_with_prefix: true -> ignore_binary_files: false). This currently fails because the converter does not negate the value when renaming the field.
V0's build/detect_binary_files_with_prefix is the logical inverse of V1's build/prefix_detection/ignore_binary_files, but the converter moved the key without negating the value. This produced recipes with inverted binary prefix-replacement behavior (e.g. breaking texlive-core's kpathsea relocation). Negate the boolean as part of the move.
5 tasks
Collaborator
|
I probably won't get to this until tomorrow, but let's at least get those CI checks running in the meantime. Thanks! |
schuylermartin45
approved these changes
Jun 24, 2026
schuylermartin45
left a comment
schuylermartin45
left a comment
Collaborator
There was a problem hiding this comment.
CEP-0014 arguably should have highlighted this nuance, but this makes a lot of sense. Thanks for catching this!
I'm not sure when we'll next release CRM, but this will be in it. We always appreciate the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In conda-forge/texlive-core-feedstock#110
conda-recipe-managerincorrectly converted the recipe due to the boolean flag fordetect_binary_files_with_prefixnot being inverted when it was renamed toignore_binary_files.This PR adds a test and fixes it.