Skip to content

Commit aa7de92

Browse files
Merge pull request #676 from conductor-oss/upgrade-protobuf-4.33.0
Upgrade protobuf to 4.33.0 (Security Fix)
2 parents cde51bc + bc5839f commit aa7de92

File tree

5 files changed

+716
-802
lines changed

5 files changed

+716
-802
lines changed

annotations-processor/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ dependencies {
88
api 'com.google.guava:guava:31.1-jre'
99
api 'com.squareup:javapoet:1.13.0'
1010
api 'com.github.jknack:handlebars:4.5.0'
11-
api 'com.google.protobuf:protobuf-java:3.21.12'
11+
api "com.google.protobuf:protobuf-java:${revProtoBuf}"
1212
api 'jakarta.annotation:jakarta.annotation-api:2.1.1'
1313
api gradleApi()
1414

dependencies.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ ext {
3333
revHamcrestAllMatchers = '1.8'
3434
revHealth = '1.1.4'
3535
revPostgres = '42.7.2'
36-
revProtoBuf = '3.25.5'
36+
revProtoBuf = '4.33.0'
3737
revJakartaAnnotation = '2.1.1'
3838
revJAXB = '4.0.1'
3939
revJAXRS = '4.0.0'

grpc/build.gradle

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313

1414
buildscript {
1515
dependencies {
16-
classpath 'com.google.protobuf:protobuf-gradle-plugin:0.8.19'
16+
classpath 'com.google.protobuf:protobuf-gradle-plugin:0.9.5'
1717
}
1818
}
1919

2020
plugins {
2121
id 'java'
2222
id 'idea'
23-
id "com.google.protobuf" version "0.8.19"
23+
id "com.google.protobuf" version "0.9.5"
2424
}
2525

2626
repositories{
@@ -42,16 +42,18 @@ dependencies {
4242

4343
}
4444

45-
def artifactName = 'com.google.protobuf:protoc:3.14.0:osx-x86_64'
45+
// Use protoc 3.25.5 for code generation to maintain compatibility with protobuf-java 4.x runtime
46+
// See: https://github.com/grpc/grpc-java/issues/12246
47+
def artifactName = 'com.google.protobuf:protoc:3.25.5'
4648
switch (org.gradle.internal.os.OperatingSystem.current()) {
4749
case org.gradle.internal.os.OperatingSystem.LINUX:
48-
artifactName = "com.google.protobuf:protoc:3.21.12"
50+
artifactName = "com.google.protobuf:protoc:3.25.5"
4951
break;
5052
case org.gradle.internal.os.OperatingSystem.MAC_OS:
51-
artifactName = "com.google.protobuf:protoc:3.14.0:osx-x86_64"
53+
artifactName = "com.google.protobuf:protoc:3.25.5"
5254
break;
5355
case org.gradle.internal.os.OperatingSystem.WINDOWS:
54-
artifactName = "com.google.protobuf:protoc:3.21.12"
56+
artifactName = "com.google.protobuf:protoc:3.25.5"
5557
break;
5658
}
5759

0 commit comments

Comments
 (0)