Skip to content

Improve http connection test #1109

@JamesHarris-orkes

Description

@JamesHarris-orkes

This appears to be a test that attempts a timeout. The test asserts that the entire timeout occurred, but that isn't the only failure condition. Some valid networks can respond that the network address is unreachable in less time than the timeout. Instead of using an rfc1918 address, expecting a full time out it would be better to select an address from 127/8 (eg 127.1.2.3) that should do as the code intends, wait the full timeout for a connection failure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions