fix: SWITCH task no longer falls through to defaultCase when matched case is empty#1158
Closed
nthmost-orkes wants to merge 1 commit into
Closed
Conversation
…case is empty An empty decisionCase list (e.g. "true": []) was treated the same as no matching case, causing the workflow to execute defaultCase tasks even when the expression evaluated to a known case key. The fallback now triggers only when no key matches (null), not when the matched case has zero tasks. Fixes conductor-oss#396
nthmost-orkes
force-pushed
the
fix/396-switch-empty-case-falls-through-to-default
branch
from
e167d5a to
9ec2739
Compare
Contributor
Author
|
Closing to reopen with a clean commit history. |
nthmost-orkes
deleted the
fix/396-switch-empty-case-falls-through-to-default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SWITCHtask evaluates to a case key that exists indecisionCasesbut has an empty task list (e.g."true": []), the workflow was incorrectly executing thedefaultCasetasks.SwitchTaskMappertreatedselectedTasks.isEmpty()the same asselectedTasks == null, collapsing the distinction between "no key matched" and "key matched, no tasks."isEmpty()check so the fallback only triggers onnull(no matching key).User impact
Users who intentionally defined an empty SWITCH branch (a "no-op" path) saw their workflow take the
defaultCasepath instead — potentially triggering termination tasks or other unintended steps even though the expression evaluated correctly.Changes
SwitchTaskMapper.java: remove|| selectedTasks.isEmpty()from the defaultCase fallback conditionSwitchTaskMapperTest.java: addgetMappedTasksWithEmptyMatchedCasetest that asserts only the SWITCH task itself is scheduled (not the defaultCase task) when the matched case has no tasksFixes #396