Merge pull request #444 from conductor-oss/fix/dynamic-fork-tasks-param

fix: restore dynamic_fork_tasks_param in DynamicForkTask (re-fixes #349)

Author: nthmost-orkes

src/conductor/client/workflow/task/dynamic_fork_task.py

@@ -20,7 +20,7 @@ def __init__(self, task_ref_name: str, tasks_param: str = "dynamicTasks", tasks_
 
     def to_workflow_task(self) -> WorkflowTask:
         wf_task = super().to_workflow_task()
-        wf_task.dynamic_fork_join_tasks_param = self.tasks_param
+        wf_task.dynamic_fork_tasks_param = self.tasks_param
         wf_task.dynamic_fork_tasks_input_param_name = self.tasks_input_param_name
         tasks = [
             wf_task,

tests/unit/workflow/test_dynamic_fork_task.py

@@ -0,0 +1,32 @@
+import unittest
+
+from conductor.client.workflow.task.dynamic_fork_task import DynamicForkTask
+from conductor.client.workflow.task.join_task import JoinTask
+
+
+class TestDynamicForkTask(unittest.TestCase):
+    def test_to_workflow_task_uses_dynamic_fork_tasks_param(self):
+        task = DynamicForkTask(
+            task_ref_name="fork",
+            tasks_param="myTasks",
+            tasks_input_param_name="myTasksInput",
+        )
+        tasks = task.to_workflow_task()
+        wf_task = tasks[0]
+        self.assertEqual(wf_task.dynamic_fork_tasks_param, "myTasks")
+        self.assertEqual(wf_task.dynamic_fork_tasks_input_param_name, "myTasksInput")
+        self.assertIsNone(wf_task.dynamic_fork_join_tasks_param)
+
+    def test_to_workflow_task_with_join(self):
+        join = JoinTask("join", join_on=[])
+        task = DynamicForkTask(task_ref_name="fork", join_task=join)
+        tasks = task.to_workflow_task()
+        self.assertEqual(len(tasks), 2)
+        self.assertEqual(tasks[0].dynamic_fork_tasks_param, "dynamicTasks")
+        self.assertEqual(tasks[0].dynamic_fork_tasks_input_param_name, "dynamicTasksInputs")
+        self.assertIsNone(tasks[0].dynamic_fork_join_tasks_param)
+        self.assertEqual(tasks[1].task_reference_name, "join")
+
+
+if __name__ == "__main__":
+    unittest.main()