Commit 7d00604
committed
refactor(async): remove unused global evaluation task cache
We now track and gather tasks per loop. The global cache is no longer
read and is not needed. The cache posed cross loop task management
risks, which is why we have moved away from it.
- Delete `global_evaluation_tasks` singleton and related imports.
- Stop appending to the global cache in `EvaluationDataset.evaluate()`;
still coerce the task to ensure validation/side effects run.
- Remove finalizers that cleared the global cache in
`execute.py` looped paths.1 parent c99a18e commit 7d00604
3 files changed
Lines changed: 1 addition & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
| |||
1238 | 1237 | | |
1239 | 1238 | | |
1240 | 1239 | | |
1241 | | - | |
| 1240 | + | |
1242 | 1241 | | |
1243 | 1242 | | |
1244 | 1243 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | 45 | | |
47 | 46 | | |
48 | 47 | | |
| |||
1719 | 1718 | | |
1720 | 1719 | | |
1721 | 1720 | | |
1722 | | - | |
1723 | | - | |
1724 | | - | |
1725 | | - | |
1726 | 1721 | | |
1727 | 1722 | | |
1728 | 1723 | | |
| |||
2069 | 2064 | | |
2070 | 2065 | | |
2071 | 2066 | | |
2072 | | - | |
2073 | | - | |
2074 | | - | |
2075 | | - | |
2076 | 2067 | | |
2077 | 2068 | | |
2078 | 2069 | | |
| |||
0 commit comments