Skip to content

Commit 9243f17

Browse files
committed
fix(metrics): use None default for turn_params in convert_turn_to_dict
Replaces the mutable list default with None + guard, mirroring the pattern applied to `goldens` in #2792. Not a live bug today — the function body doesn't mutate turn_params — but a latent footgun as callers get added (5 modules already use this helper).
1 parent 11375f8 commit 9243f17

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

deepeval/metrics/utils.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,10 @@ def format_turns(
122122

123123
def convert_turn_to_dict(
124124
turn: Turn,
125-
turn_params: List[MultiTurnParams] = [
126-
MultiTurnParams.CONTENT,
127-
MultiTurnParams.ROLE,
128-
],
125+
turn_params: Optional[List[MultiTurnParams]] = None,
129126
) -> Dict:
127+
if turn_params is None:
128+
turn_params = [MultiTurnParams.CONTENT, MultiTurnParams.ROLE]
130129
result = {}
131130
for param in turn_params:
132131
if param in (

0 commit comments

Comments
 (0)