Skip to content

Commit ffb3ce5

Browse files
committed
fix(async,ci): skip secret-dependent tests
- Add ignores for tests requiring OpenAI secrets.
1 parent d521f82 commit ffb3ce5

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

.github/workflows/test_core.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,5 @@ jobs:
9898
poetry run pytest -vv -rA --maxfail=1 --capture=tee-sys tests/test_core/test_synthesizer/ tests/test_core/test_datasets/ \
9999
--ignore=tests/test_core/test_tracing/test_dataset_iterator.py \
100100
--ignore=tests/test_core/test_synthesizer/test_context_generator.py \
101-
--ignore=tests/test_core/test_synthesizer/test_conversation_simulator.py
101+
--ignore=tests/test_core/test_synthesizer/test_conversation_simulator.py \
102+
--ignore=tests/test_core/test_synthesizer/test_generate_from_goldens.py

deepeval/evaluate/execute.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1952,10 +1952,7 @@ def on_task_done(t: asyncio.Task):
19521952
)
19531953
for t in leftovers:
19541954
meta = task_meta.get(t, {})
1955-
# Use get_name() if available, else repr()
1956-
name = (
1957-
t.get_name() if hasattr(t, "get_name") else repr(t)
1958-
)
1955+
name = t.get_name()
19591956
logger.warning(" - STRAY %s meta=%s", name, meta)
19601957

19611958
for t in leftovers:

0 commit comments

Comments
 (0)