Skip to content

Commit 928694b

Browse files
authored
Prepare v11.4.0 release (#82)
* Upgrade to configcat-common v9.4.0 * Adjust tests * Prevent circular reference error when logging request options in HttpConfigFetcher * Bump version
1 parent aab62e1 commit 928694b

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

.vscode/launch.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
"request": "launch",
77
"name": "Run tests",
88
"cwd": "${workspaceRoot}",
9+
"env": {
10+
"NODE_EXTRA_CA_CERTS": "${workspaceRoot}/test/cert/testCA.pem"
11+
},
912
"runtimeArgs": [
1013
"--expose-gc"
1114
],

package-lock.json

Lines changed: 7 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "configcat-node",
3-
"version": "11.3.1",
3+
"version": "11.4.0",
44
"description": "Official ConfigCat SDK to help you access your feature flags from a Node.js application.",
55
"main": "lib/client.js",
66
"types": "lib/client.d.ts",
@@ -32,7 +32,7 @@
3232
},
3333
"engine-strict": true,
3434
"dependencies": {
35-
"configcat-common": "9.3.1",
35+
"configcat-common": "9.4.0",
3636
"tslib": "^2.4.1",
3737
"tunnel": "0.0.6"
3838
},

src/config-fetcher.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,10 @@ export class HttpConfigFetcher implements IConfigFetcher {
7575
},
7676
timeout: options.requestTimeoutMs,
7777
};
78-
options.logger.debug(JSON.stringify(requestOptions));
78+
79+
if (options.logger.isEnabled(LogLevel.Debug)) {
80+
options.logger.debug("HttpConfigFetcher.fetchAsync() requestOptions: " + JSON.stringify({ ...requestOptions, agent: agent?.toString() }));
81+
}
7982

8083
const request = (isBaseUrlSecure ? https : http).get(baseUrl, requestOptions, response => this.handleResponse(response, resolve, reject))
8184
.on("timeout", () => {

test/http-tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ describe("HTTP tests", () => {
5959
const defaultValue = "NOT_CAT";
6060
assert.strictEqual(defaultValue, await client.getValueAsync("stringDefaultCat", defaultValue));
6161

62-
assert.isDefined(logger.messages.find(([level, msg]) => level === LogLevel.Error && msg.startsWith("Your SDK Key seems to be wrong.")));
62+
assert.isDefined(logger.messages.find(([level, msg]) => level === LogLevel.Error && msg.startsWith("Your SDK Key seems to be wrong:")));
6363
});
6464

6565
it("Unexpected status code", async () => {

0 commit comments

Comments
 (0)