Skip to content

Commit 3ee4497

Browse files
milindlmilindl
authored
Import librdkafka 2.5.3 (#1287)
2 parents a1f474a + f2d295f commit 3ee4497

23 files changed

+368
-356
lines changed

‎.semaphore/semaphore.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ agent:
66
global_job_config:
77
env_vars:
88
- name: LIBRDKAFKA_VERSION
9-
value: v2.5.3-RC1
9+
value: v2.5.3
1010
prologue:
1111
commands:
1212
- checkout

‎CHANGELOG.md

+12
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,18 @@ There were no v2.5.1 or v2.5.2 releases.
2323

2424
# v2.5.0
2525

26+
> [!WARNING]
27+
This version has introduced a regression in which an assert is triggered during **PushTelemetry** call. This happens when no metric is matched on the client side among those requested by broker subscription.
28+
>
29+
> You won't face any problem if:
30+
> * Broker doesn't support [KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability).
31+
> * [KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability) feature is disabled on the broker side.
32+
> * [KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability) feature is disabled on the client side. This is enabled by default. Set configuration `enable.metrics.push` to `false`.
33+
> * If [KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability) is enabled on the broker side and there is no subscription configured there.
34+
> * If [KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability) is enabled on the broker side with subscriptions that match the [KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability) metrics defined on the client.
35+
>
36+
> Having said this, we strongly recommend using `v2.5.3` and above to not face this regression at all.
37+
2638
This is a feature release.
2739

2840
* Adds an AdminAPI `DeleteRecords()` (#1141, @PratRanj07).

‎examples/docker_aws_lambda_example/go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module docker_example
22

33
require (
44
github.com/aws/aws-lambda-go v1.27.0
5-
github.com/confluentinc/confluent-kafka-go/v2 v2.5.3-RC1
5+
github.com/confluentinc/confluent-kafka-go/v2 v2.5.3
66
)
77

88
go 1.21

‎examples/go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ replace github.com/confluentinc/confluent-kafka-go/v2 => ../
99
require (
1010
github.com/actgardner/gogen-avro/v10 v10.2.1
1111
github.com/alecthomas/kingpin v2.2.6+incompatible
12-
github.com/confluentinc/confluent-kafka-go/v2 v2.5.3-RC1
12+
github.com/confluentinc/confluent-kafka-go/v2 v2.5.3
1313
github.com/gdamore/tcell v1.4.0
1414
google.golang.org/protobuf v1.33.0
1515
)

‎kafka/api.html

+308-308
Large diffs are not rendered by default.

‎kafka/build_darwin_amd64.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ package kafka
1010
import "C"
1111

1212
// LibrdkafkaLinkInfo explains how librdkafka was linked to the Go client
13-
const LibrdkafkaLinkInfo = "static darwin_amd64 from librdkafka-static-bundle-v2.5.3-RC1.tgz"
13+
const LibrdkafkaLinkInfo = "static darwin_amd64 from librdkafka-static-bundle-v2.5.3.tgz"

‎kafka/build_darwin_arm64.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ package kafka
1010
import "C"
1111

1212
// LibrdkafkaLinkInfo explains how librdkafka was linked to the Go client
13-
const LibrdkafkaLinkInfo = "static darwin_arm64 from librdkafka-static-bundle-v2.5.3-RC1.tgz"
13+
const LibrdkafkaLinkInfo = "static darwin_arm64 from librdkafka-static-bundle-v2.5.3.tgz"

‎kafka/build_glibc_linux_amd64.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ package kafka
1010
import "C"
1111

1212
// LibrdkafkaLinkInfo explains how librdkafka was linked to the Go client
13-
const LibrdkafkaLinkInfo = "static glibc_linux_amd64 from librdkafka-static-bundle-v2.5.3-RC1.tgz"
13+
const LibrdkafkaLinkInfo = "static glibc_linux_amd64 from librdkafka-static-bundle-v2.5.3.tgz"

‎kafka/build_glibc_linux_arm64.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ package kafka
1010
import "C"
1111

1212
// LibrdkafkaLinkInfo explains how librdkafka was linked to the Go client
13-
const LibrdkafkaLinkInfo = "static glibc_linux_arm64 from librdkafka-static-bundle-v2.5.3-RC1.tgz"
13+
const LibrdkafkaLinkInfo = "static glibc_linux_arm64 from librdkafka-static-bundle-v2.5.3.tgz"

‎kafka/build_musl_linux_amd64.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ package kafka
1010
import "C"
1111

1212
// LibrdkafkaLinkInfo explains how librdkafka was linked to the Go client
13-
const LibrdkafkaLinkInfo = "static musl_linux_amd64 from librdkafka-static-bundle-v2.5.3-RC1.tgz"
13+
const LibrdkafkaLinkInfo = "static musl_linux_amd64 from librdkafka-static-bundle-v2.5.3.tgz"

‎kafka/build_musl_linux_arm64.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ package kafka
1010
import "C"
1111

1212
// LibrdkafkaLinkInfo explains how librdkafka was linked to the Go client
13-
const LibrdkafkaLinkInfo = "static musl_linux_arm64 from librdkafka-static-bundle-v2.5.3-RC1.tgz"
13+
const LibrdkafkaLinkInfo = "static musl_linux_arm64 from librdkafka-static-bundle-v2.5.3.tgz"

‎kafka/build_windows.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ package kafka
1010
import "C"
1111

1212
// LibrdkafkaLinkInfo explains how librdkafka was linked to the Go client
13-
const LibrdkafkaLinkInfo = "static windows from librdkafka-static-bundle-v2.5.3-RC1.tgz"
13+
const LibrdkafkaLinkInfo = "static windows from librdkafka-static-bundle-v2.5.3.tgz"

‎kafka/generated_errors.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package kafka
22

33
// Copyright 2016-2024 Confluent Inc.
4-
// AUTOMATICALLY GENERATED ON 2024-09-02 08:57:47.119730045 +0530 IST m=+0.004351436 USING librdkafka 2.5.3-RC1
4+
// AUTOMATICALLY GENERATED ON 2024-09-02 16:16:32.144950005 +0530 IST m=+0.000136202 USING librdkafka 2.5.3
55

66
/*
77
#include "select_rdkafka.h"

‎kafka/librdkafka_vendor/librdkafka_darwin_amd64.a

0 Bytes
Binary file not shown.

‎kafka/librdkafka_vendor/librdkafka_darwin_arm64.a

-88 Bytes
Binary file not shown.

‎kafka/librdkafka_vendor/librdkafka_glibc_linux_amd64.a

0 Bytes
Binary file not shown.

‎kafka/librdkafka_vendor/librdkafka_glibc_linux_arm64.a

-16 Bytes
Binary file not shown.

‎kafka/librdkafka_vendor/librdkafka_musl_linux_amd64.a

0 Bytes
Binary file not shown.

‎kafka/librdkafka_vendor/librdkafka_musl_linux_arm64.a

-8 Bytes
Binary file not shown.

‎kafkatest/go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ replace github.com/confluentinc/confluent-kafka-go/v2 => ../
88

99
require (
1010
github.com/alecthomas/kingpin v2.2.6+incompatible
11-
github.com/confluentinc/confluent-kafka-go/v2 v2.5.3-RC1
11+
github.com/confluentinc/confluent-kafka-go/v2 v2.5.3
1212
)
1313

1414
require (

‎mk/doc-gen.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def convert_path(url, base_url, after):
2424
sys.exit(1)
2525
package = sys.argv[1]
2626

27-
tag = "v2.5.3-RC1"
27+
tag = "v2.5.3"
2828
major = tag.split(".")[0] # e.g. v2
2929
base_css = "https://go.dev/css"
3030
base_js = "https://go.dev/js"

0 commit comments

Comments
 (0)