[ANSIENG-5740] | Fix lint warnings (#2366)

Author: rkunwar-28

roles/common/tasks/config_validations.yml

@@ -3,7 +3,7 @@
   shell:
     cmd: set -o pipefail; openssl pkey -pubout | openssl md5
     stdin: "{{ lookup('file', ssl_key_filepath) }}"
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: key_hash_local
   delegate_to: localhost
   changed_when: false
@@ -31,7 +31,7 @@
   shell:
     cmd: set -o pipefail; openssl pkey -pubout | openssl md5
     stdin: "{{ remote_key['results'][group_idx].content | b64decode }}"
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: key_hash_remote
   changed_when: false
   when:
@@ -48,7 +48,7 @@
   shell:
     cmd: set -o pipefail; openssl x509 -noout -pubkey | openssl md5
     stdin: "{{ lookup('file', ssl_signed_cert_filepath) }}"
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: cert_hash_local
   delegate_to: localhost
   changed_when: false
@@ -76,7 +76,7 @@
   shell:
     cmd: set -o pipefail; openssl x509 -noout -pubkey | openssl md5
     stdin: "{{ remote_cert['results'][group_idx].content | b64decode }}"
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: cert_hash_remote
   changed_when: false
   when:

roles/common/tasks/masterkey.yml

@@ -13,7 +13,7 @@
       --local-secrets-file /tmp/security.properties \
       --passphrase @/tmp/passphrase.txt | awk '/Master/{print $5}'
   args:
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: masterkey
   changed_when: true
   diff: "{{ not mask_sensitive_diff|bool }}"

roles/kafka_broker/tasks/set_principal.yml

@@ -41,7 +41,7 @@
         | cut -c2- \
         | sed 's/\s*,\s*/,/g'
   args:
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: distinguished_name_from_keystore
   changed_when: false
   when:

roles/kafka_controller/tasks/health_check.yml

@@ -17,7 +17,7 @@
     {{ binary_base_path }}/bin/kafka-metadata-quorum --bootstrap-server {{inventory_hostname}}:{{kafka_controller_port}} \
       --command-config {{kafka_controller.client_config_file}} describe --replication |  grep -v Observer | awk '{print $2}'
   args:
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   environment:
     KAFKA_OPTS: "-Xlog:all=error -XX:+IgnoreUnrecognizedVMOptions {% if kerberos_client_config_file_dest != '/etc/krb5.conf' %}-Djava.security.krb5.conf={{kerberos_client_config_file_dest}}{% endif %}"
   register: leo

roles/kafka_controller/tasks/set_principal.yml

@@ -41,7 +41,7 @@
         | cut -c2- \
         | sed 's/\s*,\s*/,/g'
   args:
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: distinguished_name_from_keystore
   changed_when: false
   when:

roles/ksql/tasks/set_principal.yml

@@ -39,7 +39,7 @@
         | sed 's/^.*CN=//' \
         | cut -d "," -f1
   args:
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: distinguished_name_from_keystore
   changed_when: false
   when:

roles/ssl/tasks/export_certs_from_keystore_and_truststore.yml

@@ -19,7 +19,7 @@
       | cut -d ":" -f2 \
       | cut -c2-
   args:
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: keytool_type
   changed_when: false
   no_log: "{{mask_secrets|bool}}"

roles/ssl/tasks/import_ca_chain.yml

@@ -10,7 +10,7 @@
     set -o pipefail
     cat {{ca_cert_path}} | awk 'split_after==1{n++;split_after=0} /-----END CERTIFICATE-----/ {split_after=1} {print > ("{{ ssl_file_dir_final }}/generation/trustCAs/ca" n ".pem")}'
   args:
-    executable: /bin/bash
+    executable: "{{ shell_executable }}"
   register: split_ca_result
   changed_when: split_ca_result.rc == 0
 

roles/variables/defaults/main.yml

@@ -25,6 +25,9 @@ mask_sensitive_logs: "{{mask_secrets}}"
 ### Boolean to mask output generated by diff flag
 mask_sensitive_diff: true
 
+### Path to bash executable for shell tasks that require pipefail. Override if bash is at a different location on your systems.
+shell_executable: /bin/bash
+
 ### To copy from Ansible control host or download
 jolokia_url_remote: true