Separate handle of streaming timeout settings

[catchv]

feature request

• http.Server{ WriteTimeout: } is set as the timeout for all handlers.
• https://connectrpc.com/docs/go/deployment#timeouts-and-connection-pools
• net/http: no way of manipulating timeouts in Handler golang/go#16100
• http.NewResponseController is supported starting with Go 1.20.

solve

• Introduce a timeout option when creating a New~ServiceHandler in generate.
  (HandlerOption SetTimeout)

sample code

func NewGreetStreamServiceHandler(svc GreetStreamServiceHandler, opts ...connect.HandlerOption) (string, http.Handler) {
	greetStreamServiceMethods := v1.File_greet_v1_greet_proto.Services().ByName("GreetStreamService").Methods()
	greetStreamServiceGreetStreamHandler := connect.NewClientStreamHandler(
		GreetStreamServiceGreetStreamProcedure,
		svc.GreetStream,
		connect.WithSchema(greetStreamServiceMethods.ByName("GreetStream")),
		connect.WithHandlerOptions(opts...),
	)
	return "/greet.v1.GreetStreamService/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		switch r.URL.Path {
		case GreetStreamServiceGreetStreamProcedure:
			// ************************************************
			// NewResponseController Set Timeout 			
			rc := http.NewResponseController(w)
			rc.SetWriteDeadline(time.Now().Add(20 * time.Second))
			// ************************************************
			greetStreamServiceGreetStreamHandler.ServeHTTP(w, r)
		default:
			http.NotFound(w, r)
		}
	})
}

Thanks.

[R4R3D1FF]

I may be wrong but I think you can wrap the http.Handler you get in http.TimeoutHandler?

func main() {
greeter := &GreetServer{}
mux := http.NewServeMux()
path, handler := greetv1connect.NewGreetServiceHandler(greeter)
mux.Handle(path, http.TimeoutHandler(handler, 5*time.Second, "Youre too slow"))
http.ListenAndServe(
"localhost:8080",
// Use h2c so we can serve HTTP/2 without TLS.
h2c.NewHandler(mux, &http2.Server{}),
)
}

[R4R3D1FF]

I may be wrong but I think you can wrap the http.Handler you get in http.TimeoutHandler?

func main() { greeter := &GreetServer{} mux := http.NewServeMux() path, handler := greetv1connect.NewGreetServiceHandler(greeter) mux.Handle(path, http.TimeoutHandler(handler, 5*time.Second, "Youre too slow")) http.ListenAndServe( "localhost:8080", // Use h2c so we can serve HTTP/2 without TLS. h2c.NewHandler(mux, &http2.Server{}), ) }

Ah, nvm, this is for actual execution timeout, while ReadTimeout and WriteTimeout are for the time taken to actually read and write

[catchv]

Please note that I created a middleware to use before the official reflection.

deadline middleware