Skip to content

Commit 7374afe

Browse files
authored
Use semantic names in CI jobs instead of numbers (#77)
This also updates the README to describe the recent changes to Go version support. And it tweaks the minimum Go version in `go.mod` to reference a valid toolchain instead of just a language level (for consistency with connect-go repo).
1 parent 116a3dd commit 7374afe

3 files changed

Lines changed: 11 additions & 6 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@ permissions:
1212
contents: read
1313
jobs:
1414
ci:
15+
name: ci (go:${{ matrix.go-version.name }})
1516
runs-on: ubuntu-latest
1617
strategy:
1718
matrix:
18-
go-version: [1.23.x, 1.24.x]
19+
go-version:
20+
- name: latest
21+
version: 1.24.x
22+
- name: previous
23+
version: 1.23.x
1924
steps:
2025
- name: Checkout Code
2126
uses: actions/checkout@v4
@@ -24,11 +29,11 @@ jobs:
2429
- name: Install Go
2530
uses: actions/setup-go@v5
2631
with:
27-
go-version: ${{ matrix.go-version }}
32+
go-version: ${{ matrix.go-version.version }}
2833
- name: Test
2934
run: make test
3035
- name: Lint
3136
# Often, lint & gofmt guidelines depend on the Go version. To prevent
3237
# conflicting guidance, run only on the most recent supported version.
33-
if: matrix.go-version == '1.24.x'
38+
if: matrix.go-version.name == 'latest'
3439
run: make checkgenerate && make lint

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ func main() {
5454

5555
This module is stable. It supports:
5656

57-
* The three most recent major releases of Go. Keep in mind that [only the last
58-
two releases receive security patches][go-support-policy].
57+
* The two most recent major releases of Go (the same version of Go that continue to
58+
[eceive security patches][go-support-policy]).
5959
* [APIv2] of Protocol Buffers in Go (`google.golang.org/protobuf`).
6060

6161
Within those parameters, `grpchealth` follows semantic versioning.

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module connectrpc.com/grpchealth
22

3-
go 1.23
3+
go 1.23.0
44

55
retract v1.1.1 // module cache poisoned, use v1.1.2
66

0 commit comments

Comments
 (0)