Address code quality issues flagged by Sonar

Author: conorheffron

src/main/java/net/ironoc/portfolio/controller/BrewGraphqlController.java

@@ -13,9 +13,9 @@
 @Controller
 public class BrewGraphqlController extends AbstractLogger {
 
-    @Autowired
     private final BrewsResolver brewsResolver;
 
+    @Autowired
     public BrewGraphqlController(BrewsResolver brewsResolver) {
         this.brewsResolver = brewsResolver;
     }

src/main/java/net/ironoc/portfolio/controller/DonateGraphqlController.java

@@ -23,9 +23,9 @@ public class DonateGraphqlController extends AbstractLogger {
 
     private final Sinks.Many<Donate> donateItemsSubscriptionSink = Sinks.many().multicast().onBackpressureBuffer(256, false);
 
-    @Autowired
     private final DonateItemsResolver donateItemsResolver;
 
+    @Autowired
     public DonateGraphqlController(DonateItemsResolver donateItemsResolver) {
         this.donateItemsResolver = donateItemsResolver;
     }

src/main/java/net/ironoc/portfolio/controller/DonateRestController.java

@@ -17,9 +17,9 @@
 @RequestMapping("/api")
 public class DonateRestController {
 
-    @Autowired
     private final DonateItemsResolver donateItemsResolver;
 
+    @Autowired
     public DonateRestController(DonateItemsResolver donateItemsResolver) {
         this.donateItemsResolver = donateItemsResolver;
     }

src/main/java/net/ironoc/portfolio/service/GitDetailsService.java

@@ -68,7 +68,7 @@ public List<RepositoryDetailDto> getRepoDetails(String username, boolean isJob)
             error("Illegal argument passed for uri value: {}", uri);
         }
         if (StringUtils.isBlank(apiUri) || StringUtils.isBlank(uri)
-                | !urlUtils.isValidURL(apiUri)) {
+                || !urlUtils.isValidURL(apiUri)) {
             warn("URL is not valid: url={}", apiUri);
             return Collections.emptyList();
         }

src/test/java/net/ironoc/portfolio/controller/BaseControllerIntegrationTest.java

@@ -2,10 +2,18 @@
 
 import net.ironoc.portfolio.SeleniumConfig;
 import net.ironoc.portfolio.config.TestIronocConfiguration;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.api.extension.ExtendWith;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.TestPropertySource;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
+import org.springframework.test.context.web.WebAppConfiguration;
 
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+@ExtendWith(SpringExtension.class)
+@WebAppConfiguration()
 @ContextConfiguration(classes = {TestIronocConfiguration.class, SeleniumConfig.class})
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
 @TestPropertySource(properties = {
@@ -26,4 +34,10 @@
         "net.ironoc.portfolio.github.timeout.read=5000"
 })
 public class BaseControllerIntegrationTest {
+
+    @Test
+    public void contextLoads() {
+        // Verifies that the complete integration test context with mocks and properties loads successfully
+        assertTrue(true);
+    }
 }