Merge pull request #226 from aik099/optional-before-required-params-fix

Removed default values for mandatory parameters (PHP 8 fix)

Author: aik099

src/Jira/Api.php

@@ -759,7 +759,7 @@ public function createRemoteLink(
 	 * @return array|Result|false
 	 */
 	public function api(
-		$method = self::REQUEST_GET,
+		$method,
 		$url,
 		$data = array(),
 		$return_as_array = false,

src/Jira/Api/Client/ClientInterface.php

@@ -53,7 +53,7 @@ interface ClientInterface
 	public function sendRequest(
 		$method,
 		$url,
-		$data = array(),
+		$data,
 		$endpoint,
 		AuthenticationInterface $credential,
 		$is_file = false,

src/Jira/Api/Client/CurlClient.php

@@ -62,7 +62,7 @@ public function __construct()
 	public function sendRequest(
 		$method,
 		$url,
-		$data = array(),
+		$data,
 		$endpoint,
 		AuthenticationInterface $credential,
 		$is_file = false,

src/Jira/Api/Client/MemcacheProxyClient.php

@@ -64,7 +64,7 @@ public function __construct(ClientInterface $client, $server, $port)
 	 *
 	 * @param string                  $method     Request method.
 	 * @param string                  $url        URL.
-	 * @param array                   $data       Request data.
+	 * @param array|string            $data       Request data.
 	 * @param string                  $endpoint   Endpoint.
 	 * @param AuthenticationInterface $credential Credential.
 	 * @param boolean                 $is_file    This is a file upload request.
@@ -75,7 +75,7 @@ public function __construct(ClientInterface $client, $server, $port)
 	public function sendRequest(
 		$method,
 		$url,
-		$data = array(),
+		$data,
 		$endpoint,
 		AuthenticationInterface $credential,
 		$is_file = false,

src/Jira/Api/Client/PHPClient.php

@@ -95,7 +95,7 @@ protected function isHttpsSupported()
 	public function sendRequest(
 		$method,
 		$url,
-		$data = array(),
+		$data,
 		$endpoint,
 		AuthenticationInterface $credential,
 		$is_file = false,