Skip to content

Commit 2339aa3

Browse files
committed
address Sergey comments
Signed-off-by: Antonio Ojea <aojea@google.com>
1 parent 9a74a7b commit 2339aa3

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

docs/pod-sandbox-lifecycle.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ This NRI specification details when and under what conditions NRI plugins receiv
1414

1515
The pod sandbox lifecycle consists of three distinct phases, each with a corresponding NRI event that plugins can subscribe to:
1616

17-
1. **RunPodSandbox**: Fired during the the runtime CRI RunPodSandbox execution, after the PodSandbox is created but before setting the pod to running and then replying success to CRI RunPodSandbox request.
17+
1. **RunPodSandbox**: Fired during the runtime CRI RunPodSandbox execution, after the PodSandbox is created but before setting the pod to running and then replying success to CRI RunPodSandbox request.
1818
2. **StopPodSandbox**: Fired when the runtime initiates CRI StopPodSandbox
1919
3. **RemovePodSandbox**: Fired when the runtime performs CRI RemovePodSandbox
2020

@@ -35,6 +35,7 @@ When the runtime fires the RunPodSandbox NRI event, it guarantees:
3535

3636
- The Pod-level cgroup hierarchy has been established
3737
- The Sandbox namespaces (IPC, Network, UTS) are created and active
38+
- The Sandbox will not be reused
3839
- Network setup has been fully configured (network interfaces are up and assigned addressing)
3940
- The pod IP address (if applicable) is assigned and available
4041
- The "pause" container (if the runtime uses one) is running
@@ -138,7 +139,7 @@ These events are delivered to plugins using the RunPodSandbox, StopPodSandbox an
138139

139140
### Timeout Handling
140141

141-
All plugin processing must complete within the configured request timeout. Plugins should plan accordingly:
142+
All plugin processing must complete within the configured request timeout. A plugin timeout is treated as an error by the runtime:
142143

143144
- **RunPodSandbox**: Failure may result in pod creation failure
144145
- **StopPodSandbox**: Non-blocking for subsequent operations; the plugin should not depend on completion of subsequent teardown

0 commit comments

Comments
 (0)