Skip to content

Commit 6f2a8c1

Browse files
committed
Fix crates that depend on new ttrpc
Signed-off-by: Maksym Pavlenko <[email protected]>
1 parent 217f0ee commit 6f2a8c1

File tree

7 files changed

+10
-21
lines changed

7 files changed

+10
-21
lines changed

crates/shim-protos/examples/ttrpc-server-async.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@ impl Task for FakeServer {
6060
async fn main() {
6161
simple_logger::SimpleLogger::new().init().unwrap();
6262

63-
let t = Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>;
64-
let t = Arc::new(t);
65-
let tservice = create_task(t);
63+
let tservice = create_task(Arc::new(FakeServer::new()));
6664

6765
let mut server = Server::new()
6866
.bind("unix:///tmp/shim-proto-ttrpc-001")

crates/shim-protos/examples/ttrpc-server.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ impl Task for FakeServer {
5757
fn main() {
5858
simple_logger::SimpleLogger::new().init().unwrap();
5959

60-
let t = Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>;
61-
let t = Arc::new(t);
62-
let tservice = create_task(t);
60+
let tservice = create_task(Arc::new(FakeServer::new()));
6361

6462
let mut server = Server::new()
6563
.bind("unix:///tmp/shim-proto-ttrpc-001")

crates/shim-protos/tests/ttrpc.rs

+3-7
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ fn create_ttrpc_context() -> (
7272

7373
#[test]
7474
fn test_task_method_num() {
75-
let server = Arc::new(Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>);
76-
let task = create_task(server.clone());
77-
75+
let task = create_task(Arc::new(FakeServer::new()));
7876
assert_eq!(task.len(), 17);
7977
}
8078

@@ -98,8 +96,7 @@ fn test_create_task() {
9896
request.set_timeout_nano(10000);
9997
request.set_metadata(ttrpc::context::to_pb(ctx.metadata.clone()));
10098

101-
let server = Arc::new(Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>);
102-
let task = create_task(server.clone());
99+
let task = create_task(Arc::new(FakeServer::new()));
103100
let create = task.get("/containerd.task.v2.Task/Create").unwrap();
104101
create.handler(ctx, request).unwrap();
105102

@@ -140,8 +137,7 @@ fn test_delete_task() {
140137
request.set_timeout_nano(10000);
141138
request.set_metadata(ttrpc::context::to_pb(ctx.metadata.clone()));
142139

143-
let server = Arc::new(Box::new(FakeServer::new()) as Box<dyn Task + Send + Sync>);
144-
let task = create_task(server.clone());
140+
let task = create_task(Arc::new(FakeServer::new()));
145141
let delete = task.get("/containerd.task.v2.Task/Delete").unwrap();
146142
delete.handler(ctx, request).unwrap();
147143

crates/shim/src/asynchronous/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ where
178178

179179
let publisher = RemotePublisher::new(&ttrpc_address).await?;
180180
let task = shim.create_task_service(publisher).await;
181-
let task_service = create_task(Arc::new(Box::new(task)));
181+
let task_service = create_task(Arc::new(task));
182182
let mut server = Server::new().register_service(task_service);
183183
server = server.add_listener(SOCKET_FD)?;
184184
server = server.set_domain_unix();

crates/shim/src/asynchronous/publisher.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,7 @@ mod tests {
148148
let barrier2 = barrier.clone();
149149
let server_thread = tokio::spawn(async move {
150150
let listener = UnixListener::bind(&path1).unwrap();
151-
let t = Arc::new(Box::new(server) as Box<dyn Events + Send + Sync>);
152-
let service = create_events(t);
151+
let service = create_events(Arc::new(server));
153152
let mut server = Server::new()
154153
.set_domain_unix()
155154
.add_listener(listener.as_raw_fd())

crates/shim/src/synchronous/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ where
266266

267267
let publisher = publisher::RemotePublisher::new(&ttrpc_address)?;
268268
let task = shim.create_task_service(publisher);
269-
let task_service = create_task(Arc::new(Box::new(task)));
269+
let task_service = create_task(Arc::new(task));
270270
let mut server = create_server(flags)?;
271271
server = server.register_service(task_service);
272272
server.start()?;

crates/shim/src/synchronous/publisher.rs

+2-4
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,7 @@ mod tests {
188188
use std::os::unix::{io::AsRawFd, net::UnixListener};
189189
let listener = UnixListener::bind(server_address).unwrap();
190190
listener.set_nonblocking(true).unwrap();
191-
let t = Arc::new(Box::new(FakeServer {}) as Box<dyn Events + Send + Sync>);
192-
let service = client::create_events(t);
191+
let service = client::create_events(Arc::new(FakeServer {}));
193192
let server = Server::new()
194193
.add_listener(listener.as_raw_fd())
195194
.unwrap()
@@ -200,8 +199,7 @@ mod tests {
200199

201200
#[cfg(windows)]
202201
{
203-
let t = Arc::new(Box::new(FakeServer {}) as Box<dyn Events + Send + Sync>);
204-
let service = client::create_events(t);
202+
let service = client::create_events(Arc::new(FakeServer {}));
205203

206204
Server::new()
207205
.bind(server_address)

0 commit comments

Comments
 (0)