Path of cgroup is wrong when running a container in a container.

[aa624545345]

https://github.com/containerd/rust-extensions/blob/main/crates/shim/src/cgroup.rs#L195
cgroup-rs

[Burning1020]

Could you explain the reason more specificlly?

[aa624545345]

get_cgroups_relative_paths_by_pid returns wrong cgroup paths because relative paths obtained from /proc/.../cgroup is not the true path, they shoud be trimed with the root path get from the third column of /proc/.../mountinfo.

This error only occurs when running a container in a container, running directly on the host is fine.

A specific description can be found here: kata-containers/cgroups-rs#131.

[aa624545345]

If cgroup-rs library remains unchanged, it is possible because for kata containers, they may not have a requirement for running a container withina container. In that case, would the rust-extentions consider fixing this bug?

Bug fix for cgroup-rs is here: https://github.com/kata-containers/cgroups-rs/pull/132/commits

[aa624545345]

@Burning1020 @kzys @dims @caniszczyk Hi, cgroups-rs seems have no intention to fix this bug. The issue i rased in cgroup-rs haven't received reponse for a month. Are you intrerested in fixing it? I can submit a new pr, collect the cgroup paths after here.

[Burning1020]

@aa624545345 Hi, I notice you have committed a PR to cgroup-rs and I think it should be fixed in it because cgroup-rs is a public crate not only used in kata-containers.

[Mossaka]

I noticed there are fairly amount of activities on Kata containers slack channel so I reached out to them, hopefully I could draw attention to get some feedback for your PR, @aa624545345.

https://katacontainers.slack.com/archives/C879ACQ00/p1711667146047859

[aa624545345]

I noticed there are fairly amount of activities on Kata containers slack channel so I reached out to them, hopefully I could draw attention to get some feedback for your PR, @aa624545345.

https://katacontainers.slack.com/archives/C879ACQ00/p1711667146047859

Oh, thx.

[github-actions]

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 7 days unless new comments are made or the stale label is removed.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity.