fix: move exec inside loop#1183
Open
QxBytes wants to merge 1 commit intocontainernetworking:mainfrom
Open
Conversation
QxBytes
force-pushed
the
alew/run-exec-inside-loop
branch
2 times, most recently
from
508d95f to
1439246
Compare
aims to resolve containernetworking#855 Signed-off-by: QxBytes <39818795+QxBytes@users.noreply.github.com>
QxBytes
force-pushed
the
alew/run-exec-inside-loop
branch
from
1439246 to
fdc67a2
Compare
Contributor
|
@squeed @LionelJouin this might have been under the radar for awhile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to resolve #855
Moves exec command into the for loop so each retry gets a new instance of the command. Previously, we would retry using the same exec command which would always fail due to https://cs.opensource.google/go/go/+/refs/tags/go1.26.2:src/os/exec/exec.go;l=146 (command cannot be reused after calling
Runon it).Reran the unit test several dozen times without any flakiness.