Skip to content

Commit 8fba28b

Browse files
authored
Merge pull request #27896 from shiavm006/fix-container-export-event
Fix container export emitting incorrect event type.
2 parents 7c9d4a4 + 231dbdf commit 8fba28b

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

libpod/container_api.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ func (c *Container) Export(out io.Writer) error {
545545
return fmt.Errorf("cannot mount container %s as it is being removed: %w", c.ID(), define.ErrCtrStateInvalid)
546546
}
547547

548-
defer c.newContainerEvent(events.Mount)
548+
defer c.newContainerEvent(events.Export)
549549
return c.export(out)
550550
}
551551

test/e2e/export_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,22 @@ var _ = Describe("Podman export", func() {
5151
result.WaitWithDefaultTimeout()
5252
Expect(result).To(ExitWithError(125, "invalid filename (should not contain ':')"))
5353
})
54+
55+
It("podman export emits export event", func() {
56+
_, ec, cid := podmanTest.RunLsContainer("")
57+
Expect(ec).To(Equal(0))
58+
59+
outfile := filepath.Join(podmanTest.TempDir, "container.tar")
60+
result := podmanTest.Podman([]string{"export", "-o", outfile, cid})
61+
result.WaitWithDefaultTimeout()
62+
Expect(result).Should(ExitCleanly())
63+
64+
eventsResult := podmanTest.Podman([]string{"events", "--stream=false", "--filter", "event=export", "--since", "30s"})
65+
eventsResult.WaitWithDefaultTimeout()
66+
Expect(eventsResult).Should(ExitCleanly())
67+
events := eventsResult.OutputToStringArray()
68+
Expect(events).ToNot(BeEmpty(), "export event should be present")
69+
Expect(events[0]).To(ContainSubstring("export"))
70+
Expect(events[0]).To(ContainSubstring(cid))
71+
})
5472
})

0 commit comments

Comments
 (0)