feat: improve link checker audit workflow

Author: zacharyyankiver

apps/link-checker/__tests__/locations/ConfigScreen.spec.tsx

@@ -33,8 +33,8 @@ describe('Config Screen component', () => {
     expect(getByText(/^Deny list$/)).toBeInTheDocument();
     expect(getByText('Disclaimer')).toBeInTheDocument();
     expect(getByPlaceholderText('https://www.example.com')).toBeInTheDocument();
-    expect(getByPlaceholderText(/help\.example\.com/)).toBeInTheDocument();
-    expect(getByPlaceholderText(/staging\.example\.com/)).toBeInTheDocument();
+    expect(getByPlaceholderText('Add allowed domain...')).toBeInTheDocument();
+    expect(getByPlaceholderText('Add blocked domain...')).toBeInTheDocument();
   });
 
   it('calls onConfigure and returns parameters and targetState', async () => {

apps/link-checker/__tests__/locations/Page.spec.tsx

@@ -0,0 +1,79 @@
+import React from 'react';
+import { fireEvent, render, screen } from '@testing-library/react';
+import { mockSdk } from '../mocks';
+import Page from '@/components/locations/Page';
+
+jest.mock('@contentful/react-apps-toolkit', () => ({
+  useSDK: () => mockSdk,
+}));
+
+describe('Page component', () => {
+  beforeEach(() => {
+    mockSdk.parameters.installation = {
+      selectedContentTypeIds: ['article'],
+    };
+    mockSdk.app.getCurrentState.mockResolvedValue({
+      EditorInterface: {
+        article: { sidebar: { position: 1 } },
+      },
+    });
+    mockSdk.cma = {
+      contentType: {
+        getMany: jest.fn().mockResolvedValue({
+          items: [
+            {
+              sys: { id: 'article' },
+              name: 'Article',
+              displayField: 'title',
+              fields: [
+                { id: 'title', name: 'Title', type: 'Symbol' },
+                { id: 'body', name: 'Body', type: 'Text' },
+              ],
+            },
+          ],
+        }),
+      },
+      entry: {
+        getMany: jest.fn().mockResolvedValue({
+          items: [
+            {
+              sys: {
+                id: 'entry-1',
+                contentType: { sys: { id: 'article' } },
+              },
+              fields: {
+                title: { 'en-US': 'Release Notes' },
+                body: { 'en-US': 'Visit https://example.invalid/not-found' },
+              },
+            },
+          ],
+        }),
+      },
+      appAction: {
+        getMany: jest.fn().mockResolvedValue({
+          items: [
+            {
+              sys: {
+                id: 'check-link-action',
+                appDefinition: { sys: { id: mockSdk.ids.app } },
+              },
+              function: { sys: { id: 'checkLink' } },
+            },
+          ],
+        }),
+      },
+      appActionCall: {
+        createWithResponse: jest.fn().mockResolvedValue({
+          response: { body: JSON.stringify({ status: 404 }) },
+        }),
+      },
+    };
+  });
+
+  it('renders scanned links in the page table', async () => {
+    render(<Page />);
+    fireEvent.click(screen.getByRole('button', { name: 'Run scan' }));
+
+    await screen.findByText('https://example.invalid/not-found');
+  });
+});

apps/link-checker/__tests__/locations/Sidebar.spec.tsx

@@ -75,4 +75,57 @@ describe('Sidebar component', () => {
     await screen.findByText(/not on allow list/i);
     expect(createWithResponse).not.toHaveBeenCalled();
   });
+
+  it('shows only non-invalid results when remaining links are expanded', async () => {
+    const createWithResponse = jest
+      .fn()
+      .mockResolvedValueOnce({ response: { body: JSON.stringify({ status: 404 }) } })
+      .mockResolvedValueOnce({ response: { body: JSON.stringify({ status: 200 }) } });
+
+    mockSdk.entry.fields = {
+      body: {
+        id: 'body',
+        name: 'Body',
+        type: 'Text',
+        locales: ['en-US'],
+        getValue: () =>
+          'Broken https://broken.example.com and valid https://www.contentful.com/help',
+      },
+    };
+    mockSdk.cma = {
+      appAction: {
+        getMany: jest.fn().mockResolvedValue({
+          items: [
+            {
+              sys: {
+                id: 'check-link-action',
+                appDefinition: { sys: { id: mockSdk.ids.app } },
+              },
+              function: { sys: { id: 'checkLink' } },
+            },
+          ],
+        }),
+      },
+      appActionCall: {
+        createWithResponse,
+      },
+    };
+
+    render(<Sidebar />);
+
+    await act(async () => {
+      fireEvent.click(screen.getByRole('button', { name: /check links/i }));
+    });
+
+    await screen.findByText(/1 invalid link/i);
+    expect(screen.getByRole('checkbox', { name: /show valid links/i })).toBeInTheDocument();
+    expect(screen.getByText(/1 valid link/i)).toBeInTheDocument();
+
+    await act(async () => {
+      fireEvent.click(screen.getByRole('checkbox', { name: /show valid links/i }));
+    });
+
+    expect(screen.getByText('https://www.contentful.com/help')).toBeInTheDocument();
+    expect(screen.queryAllByText('https://broken.example.com')).toHaveLength(1);
+  });
 });

apps/link-checker/__tests__/mocks/mockSdk.ts

@@ -14,9 +14,16 @@ const mockSdk: any = {
   parameters: {
     installation: {},
   },
+  locales: {
+    default: 'en-US',
+  },
   entry: {
     fields: {},
   },
+  navigator: {
+    openEntry: jest.fn(),
+    openAppConfig: jest.fn(),
+  },
   cma: {},
   location: { is: jest.fn().mockReturnValue(false) },
 };

apps/link-checker/__tests__/utils/extractUrls.spec.ts

@@ -105,6 +105,22 @@ describe('extractUrlsFromEntry', () => {
     expect(result).toHaveLength(1);
   });
 
+  it('does not treat plain email addresses as URLs', () => {
+    const entry = {
+      fields: {
+        replyToEmail: {
+          id: 'replyToEmail',
+          name: 'Reply-to email',
+          type: 'Symbol',
+          locales: ['en-US'],
+          getValue: () => 'hello@colorful.com',
+        },
+      },
+    };
+
+    expect(extractUrlsFromEntry(entry)).toEqual([]);
+  });
+
   it('includes Rich Text hyperlink URIs', () => {
     const entry = {
       fields: {
@@ -235,5 +251,21 @@ describe('extractUrlsFromEntry', () => {
       };
       expect(extractUrlsFromEntry(entry)).toEqual([]);
     });
+
+    it('does not treat a standalone slash separator as a relative link', () => {
+      const entry = {
+        fields: {
+          title: {
+            id: 'title',
+            name: 'Title',
+            type: 'Symbol',
+            locales: ['en-US'],
+            getValue: () => 'Partners / More customers',
+          },
+        },
+      };
+
+      expect(extractUrlsFromEntry(entry)).toEqual([]);
+    });
   });
 });