Skip to content

Commit c272530

Browse files
ci: pass Vite env vars to deploy step so app-level rebuilds pick them up (#11125)
The Build and Deploy steps are separate CircleCI run steps, so inline env vars in Build don't persist to Deploy. When lerna triggers each app's deploy script (which re-runs npm run build internally), VITE_LD_CLIENT_ID and friends were unset, producing a bundle with an empty LD client ID. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 4835618 commit c272530

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.circleci/config.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ jobs:
136136
VITE_ENV='test' \
137137
REACT_APP_BACKEND_BASE_URL=$BACKEND_BASE_URL_TEST \
138138
REACT_APP_SLACK_CLIENT_ID=$SLACK_CLIENT_ID_TEST \
139+
VITE_GOOGLE_PICKER_API_KEY=$VITE_GOOGLE_PICKER_API_KEY \
140+
VITE_GOOGLE_APP_ID=$VITE_GOOGLE_APP_ID \
141+
VITE_LD_CLIENT_ID='588a047044b03e0b3211298d' \
139142
GOOGLE_DOCS_TEST_CLOUDFRONT_DIST_ID=$GOOGLE_DOCS_TEST_CLOUDFRONT_DIST_ID \
140143
STAGE='test' npm run deploy:test
141144
- run:
@@ -182,6 +185,9 @@ jobs:
182185
STATIC_KLAVIYO_S3_BASE="s3://cf-apps-klaviyo/apps" \
183186
REACT_APP_BACKEND_BASE_URL=$APP_SLACK_BACKEND_BASE_URL_PROD \
184187
REACT_APP_SLACK_CLIENT_ID=$SLACK_CLIENT_ID_PROD \
188+
VITE_GOOGLE_PICKER_API_KEY=$VITE_GOOGLE_PICKER_API_KEY \
189+
VITE_GOOGLE_APP_ID=$VITE_GOOGLE_APP_ID \
190+
VITE_LD_CLIENT_ID='588a047044b03e0b3211298e' \
185191
GOOGLE_DOCS_PROD_CLOUDFRONT_DIST_ID=$GOOGLE_DOCS_PROD_CLOUDFRONT_DIST_ID \
186192
STAGE='prd' npm run deploy
187193
- run:

0 commit comments

Comments
 (0)