Skip to content

Commit 97c7d59

Browse files
nalchevanidzeclaude
andcommitted
refactor(web-sdk_angular): remove isAuto and use manualTracking directly in template
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent aea6706 commit 97c7d59

2 files changed

Lines changed: 9 additions & 10 deletions

File tree

implementations/web-sdk_angular/src/app/components/entry-card/index.html

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
@let scenario = clickScenario();
22

33
<section [attr.data-testid]="'entry-card-' + (resolved()?.baselineId ?? '')">
4-
@if (scenario === 'ancestor' && isAuto()) {
4+
@if (scenario === 'ancestor' && !manualTracking()) {
55
<div data-ctfl-clickable="true" data-testid="entry-click-ancestor-wrapper">
66
<ng-container [ngTemplateOutlet]="entryContent" />
77
</div>
@@ -15,14 +15,14 @@
1515
<div
1616
class="entry-card"
1717
[attr.data-testid]="'content-' + r.baselineId"
18-
[attr.data-ctfl-entry-id]="isAuto() ? r.resolvedId : null"
19-
[attr.data-ctfl-baseline-id]="isAuto() ? r.baselineId : null"
20-
[attr.data-ctfl-optimization-id]="isAuto() ? (r.experienceId ?? null) : null"
21-
[attr.data-ctfl-sticky]="isAuto() ? (r.sticky !== undefined ? r.sticky.toString() : null) : null"
22-
[attr.data-ctfl-variant-index]="isAuto() ? (r.variantIndex !== undefined ? r.variantIndex.toString() : null) : null"
23-
[attr.data-ctfl-hover-duration-update-interval-ms]="isAuto() ? '1000' : null"
24-
[attr.data-ctfl-clickable]="scenario === 'direct' && isAuto() ? 'true' : null"
25-
[attr.data-entry-id]="!isAuto() ? r.baselineId : null"
18+
[attr.data-ctfl-entry-id]="manualTracking() ? null : r.resolvedId"
19+
[attr.data-ctfl-baseline-id]="manualTracking() ? null : r.baselineId"
20+
[attr.data-ctfl-optimization-id]="manualTracking() ? null : (r.experienceId ?? null)"
21+
[attr.data-ctfl-sticky]="manualTracking() ? null : (r.sticky !== undefined ? r.sticky.toString() : null)"
22+
[attr.data-ctfl-variant-index]="manualTracking() ? null : (r.variantIndex !== undefined ? r.variantIndex.toString() : null)"
23+
[attr.data-ctfl-hover-duration-update-interval-ms]="manualTracking() ? null : '1000'"
24+
[attr.data-ctfl-clickable]="manualTracking() || scenario !== 'direct' ? null : 'true'"
25+
[attr.data-entry-id]="manualTracking() ? r.baselineId : null"
2626
>
2727
<div class="entry-card__header">
2828
<div class="entry-card__ids">

implementations/web-sdk_angular/src/app/components/entry-card/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ export class EntryCard {
145145
const nested: unknown = this.resolved().entry.fields.nested
146146
return Array.isArray(nested) ? nested.filter(isContentfulEntry) : []
147147
})
148-
protected readonly isAuto = computed(() => !this.manualTracking())
149148
protected readonly badges = computed(() => {
150149
const r = this.resolved()
151150
const mergeTag = mergeTagKey(r.mergeTagResolved)

0 commit comments

Comments
 (0)