fix(files-context)-refresh-on-new-file-and-save

[chezsmithy]

Description

Resolves: #5361

• Traced the refreshes happening when new files are created and saved in the vscode UI. Noted that based on the parameter being sent to refresh the context certain contexts were being ignored noting they needed to wait for indexing to occur, but indexing was already performed before the call so I believe this was in error.
• Updated the create file tool to also make a call into refreshing the indexes. (However I'm not sure I love the sideways call into a now no longer private core function).

TODO (Recommend a separate PR):

• Could also solve for adding a file watcher to the workspace to detect changes that might be caused by the terminal tool, or made through running scripts and via that hook update the index, and the contexts.

Checklist

• I've read the contributing guide
• The relevant docs, if any, have been updated or created
• The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Testing instructions

New File in VsCode

1. Create a new file in the VsCode UI, and save it.
2. Validate the file now shows up in the @files context.

In Agent Mode

1. Ask for a new file to be created.
2. Validate the file now shows up the @files context.

[netlify]

✅ Deploy Preview for continuedev ready!

Name	Link
🔨 Latest commit	ad84143
🔍 Latest deploy log	https://app.netlify.com/sites/continuedev/deploys/681bcaeb84798d0008ae8ca8
😎 Deploy Preview	https://deploy-preview-5564--continuedev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Patrick-Erichsen]

Hey @chezsmithy , chatted with @sestinj on this. I think we'd like to avoid injecting the entire core obj as a dependency to callTool.

Instead, we're thinking of creating a more scoped class for indexing related logic, eg refreshCodebaseIndexFiles, and then we can just inject that.

I'm planning to do that next week, so once that's merged, I'll push up a commit here to use that new class, and then we can get this merged 👍

[chezsmithy]

Note to add tests related to On Save events triggering excessive indexing.

Note to review JetBrains impacts.

@Patrick-Erichsen FYI from discord.

[chezsmithy]

@Patrick-Erichsen a quick check in on the core indexing refactor?

[chezsmithy]

@Patrick-Erichsen would you like me to take a run at a new refactor PR we could iterate at? Understand you are super busy.

[Patrick-Erichsen]

Hey @chezsmithy , apologies for the delay here! Thanks for the repeated bumps on this.

If you're open to giving the the refactor an attempt that would be great. On second glance I think we could keep things even simpler and just pass refreshCodebaseIndexFiles directly as a standalone property instead of the entire core obj. Let me know your thoughts!