Skip to content

fix: Fix the misleading naming of return value Config in function loa… #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

janzwj
Copy link

@janzwj janzwj commented May 22, 2025

Fix the misleading naming of return value Config in function loadConfig within file ConfigHandle

Description

Replace Config with ConfigResult


Summary by cubic

Renamed the return value in loadConfig from Config to ConfigResult to better reflect its contents and avoid confusion.

@janzwj janzwj requested a review from a team as a code owner May 22, 2025 02:30
@janzwj janzwj requested review from Patrick-Erichsen and removed request for a team May 22, 2025 02:30
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 22, 2025
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


72192022 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

netlify bot commented May 22, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 069d499
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/682e8c60271a790008993633

@Patrick-Erichsen
Copy link
Collaborator

Closing this as an unnecessary change.

@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs May 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants