fix(app): bound LCU status refresh

Author: controlado

internal/app/app.go

@@ -13,6 +13,8 @@ import (
 
 var ErrUpdateUnavailable = errors.New("update check unavailable")
 
+const lcuStateRefreshTimeout = 750 * time.Millisecond
+
 type (
 	ServiceFactory    func(RuntimeConfig) (autobuild.Service, error)
 	LCUStatusProvider func(context.Context, RuntimeConfig) LCUStatus
@@ -131,7 +133,9 @@ func (a *App) State(ctx context.Context) ViewState {
 	if a.coachlessAuth != nil {
 		state.CoachlessAuth = cloneCoachlessAuthState(a.coachlessAuth.Status(ctx))
 	}
-	state.LCU = a.lcuStatus(ctx, configSnapshot)
+	statusCtx, cancel := context.WithTimeout(ctx, lcuStateRefreshTimeout)
+	state.LCU = a.lcuStatus(statusCtx, configSnapshot)
+	cancel()
 
 	return state
 }

internal/app/app_test.go

@@ -384,6 +384,29 @@ func TestStateCopiesCoachlessAuthState(t *testing.T) {
 	}
 }
 
+func TestStateBoundsLCUStatusRefresh(t *testing.T) {
+	app := newTestApp(t, testAppOptions{
+		lcuStatus: func(ctx context.Context, _ RuntimeConfig) LCUStatus {
+			<-ctx.Done()
+			return LCUStatus{State: LCUConnectionStateNotConnected, Message: ctx.Err().Error()}
+		},
+	})
+
+	start := time.Now()
+	state := app.State(context.Background())
+	elapsed := time.Since(start)
+
+	if elapsed > lcuStateRefreshTimeout+500*time.Millisecond {
+		t.Fatalf("State() took %v, want bounded by LCU state refresh timeout", elapsed)
+	}
+	if state.LCU.State != LCUConnectionStateNotConnected {
+		t.Fatalf("LCU state = %q, want not_connected", state.LCU.State)
+	}
+	if state.LCU.Message != context.DeadlineExceeded.Error() {
+		t.Fatalf("LCU message = %q, want deadline exceeded", state.LCU.Message)
+	}
+}
+
 func TestCoachlessAuthActionsUseSessionWithoutSavingConfig(t *testing.T) {
 	store := &recordingConfigStore{}
 	authSession := &stubCoachlessAuth{