refactor(coachless): centralize endpoints

Author: controlado

internal/auth/source.go

@@ -14,6 +14,7 @@ import (
 	"github.com/chromedp/chromedp"
 
 	"github.com/controlado/lol-autobuild/internal/autobuild/domain"
+	"github.com/controlado/lol-autobuild/internal/coachless"
 )
 
 var ErrAccessTokenUnavailable = errors.New("unable to acquire valid access token")
@@ -75,7 +76,7 @@ func (s BrowserSource) Acquire(ctx context.Context) (domain.TokenPair, error) {
 	chromedp.ListenTarget(ctx, func(ev any) {
 		switch e := ev.(type) {
 		case *network.EventResponseReceived:
-			if e.Response == nil || !strings.Contains(e.Response.URL, "/api/Auth/login") {
+			if e.Response == nil || !strings.Contains(e.Response.URL, coachless.AuthLoginPath) {
 				return
 			}
 			go onAuthResponse(e)

internal/coachless/client.go

@@ -36,12 +36,11 @@ func (c *Client) Refresh(ctx context.Context, refreshToken string) (domain.Token
 	}
 
 	var (
-		endpoint = "/api/Auth/refresh"
-		reqBody  = map[string]string{"refreshToken": refreshToken}
-		out      apiRefreshResponse
+		reqBody = map[string]string{"refreshToken": refreshToken}
+		out     apiRefreshResponse
 	)
 
-	if err := c.doJSON(ctx, http.MethodPost, endpoint, "", reqBody, &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodPost, authRefreshPath, "", reqBody, &out); err != nil {
 		return domain.TokenPair{}, err
 	}
 
@@ -58,90 +57,69 @@ func (c *Client) Refresh(ctx context.Context, refreshToken string) (domain.Token
 }
 
 func (c *Client) GetPatches(ctx context.Context, accessToken string) ([]domain.PatchInfo, error) {
-	var (
-		endpoint = "/api/ChampionWinprob/GetPatches"
-		out      []apiPatchInfo
-	)
+	var out []apiPatchInfo
 
-	if err := c.doJSON(ctx, http.MethodGet, endpoint, accessToken, nil, &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodGet, championWinprobPatchesPath, accessToken, nil, &out); err != nil {
 		return nil, err
 	}
 
 	return patchInfosFromAPI(out), nil
 }
 
 func (c *Client) GetKeystoneData(ctx context.Context, accessToken string, req domain.KeystoneRequest) ([]domain.KeystoneStat, error) {
-	var (
-		endpoint = "/api/Rune/GetKeystoneData"
-		out      []apiKeystoneStat
-	)
+	var out []apiKeystoneStat
 
-	if err := c.doJSON(ctx, http.MethodPost, endpoint, accessToken, apiKeystoneRequestFromDomain(req), &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodPost, runeKeystoneDataPath, accessToken, apiKeystoneRequestFromDomain(req), &out); err != nil {
 		return nil, err
 	}
 
 	return keystoneStatsFromAPI(out), nil
 }
 
 func (c *Client) GetSecondaryTreePlaycount(ctx context.Context, accessToken string, req domain.SecondaryTreePlaycountRequest) ([]domain.RuneTreePlaycount, error) {
-	var (
-		endpoint = "/api/Rune/GetSecondaryTreePlaycount"
-		out      []apiRuneTreePlaycount
-	)
+	var out []apiRuneTreePlaycount
 
-	if err := c.doJSON(ctx, http.MethodPost, endpoint, accessToken, apiSecondaryTreePlaycountRequestFromDomain(req), &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodPost, runeSecondaryTreePlaycountPath, accessToken, apiSecondaryTreePlaycountRequestFromDomain(req), &out); err != nil {
 		return nil, err
 	}
 
 	return runeTreePlaycountsFromAPI(out), nil
 }
 
 func (c *Client) GetRuneStatsForKeystoneAndTree(ctx context.Context, accessToken string, req domain.RuneStatsRequest) (domain.RuneStatsByRow, error) {
-	var (
-		endpoint = "/api/Rune/GetRunesForKeystoneAndTree"
-		out      apiRuneStatsByRow
-	)
+	var out apiRuneStatsByRow
 
-	if err := c.doJSON(ctx, http.MethodPost, endpoint, accessToken, apiRuneStatsRequestFromDomain(req), &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodPost, runeStatsForKeystoneAndTreePath, accessToken, apiRuneStatsRequestFromDomain(req), &out); err != nil {
 		return domain.RuneStatsByRow{}, err
 	}
 
 	return runeStatsByRowFromAPI(out), nil
 }
 
 func (c *Client) GetShardStatsForKeystoneAndTree(ctx context.Context, accessToken string, req domain.ShardStatsRequest) (domain.ShardStats, error) {
-	var (
-		endpoint = "/api/Rune/GetShardsForKeystoneAndTree"
-		out      apiShardStats
-	)
+	var out apiShardStats
 
-	if err := c.doJSON(ctx, http.MethodPost, endpoint, accessToken, apiShardStatsRequestFromDomain(req), &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodPost, runeShardsForKeystoneAndTreePath, accessToken, apiShardStatsRequestFromDomain(req), &out); err != nil {
 		return domain.ShardStats{}, err
 	}
 
 	return shardStatsFromAPI(out), nil
 }
 
 func (c *Client) GetSummonerSpellStats(ctx context.Context, accessToken string, req domain.SummonerSpellStatsRequest) ([]domain.SummonerSpellStat, error) {
-	var (
-		out      []apiSummonerSpellStat
-		endpoint = "/api/ChampionWinprob/GetGlobalSummonerSpellStatistics"
-	)
+	var out []apiSummonerSpellStat
 
-	if err := c.doJSON(ctx, http.MethodPost, endpoint, accessToken, apiSummonerSpellStatsRequestFromDomain(req), &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodPost, championWinprobSummonerSpellStatsPath, accessToken, apiSummonerSpellStatsRequestFromDomain(req), &out); err != nil {
 		return nil, err
 	}
 
 	return summonerSpellStatsFromAPI(out), nil
 }
 
 func (c *Client) GetItemStats(ctx context.Context, accessToken string, req domain.ItemStatsRequest) ([]domain.ItemStat, error) {
-	var (
-		out      []apiItemStat
-		endpoint = "/api/ChampionWinprob/GetGlobalItemStatistics"
-	)
+	var out []apiItemStat
 
-	if err := c.doJSON(ctx, http.MethodPost, endpoint, accessToken, apiItemStatsRequestFromDomain(req), &out); err != nil {
+	if err := c.doJSON(ctx, http.MethodPost, championWinprobItemStatsPath, accessToken, apiItemStatsRequestFromDomain(req), &out); err != nil {
 		return nil, err
 	}
 

internal/coachless/endpoints.go

@@ -0,0 +1,15 @@
+package coachless
+
+const (
+	AuthLoginPath   = "/api/Auth/login"
+	authRefreshPath = "/api/Auth/refresh"
+
+	championWinprobPatchesPath            = "/api/ChampionWinprob/GetPatches"
+	championWinprobSummonerSpellStatsPath = "/api/ChampionWinprob/GetGlobalSummonerSpellStatistics"
+	championWinprobItemStatsPath          = "/api/ChampionWinprob/GetGlobalItemStatistics"
+
+	runeKeystoneDataPath             = "/api/Rune/GetKeystoneData"
+	runeSecondaryTreePlaycountPath   = "/api/Rune/GetSecondaryTreePlaycount"
+	runeStatsForKeystoneAndTreePath  = "/api/Rune/GetRunesForKeystoneAndTree"
+	runeShardsForKeystoneAndTreePath = "/api/Rune/GetShardsForKeystoneAndTree"
+)