Can't release because commit does not validate with commitlint

[satazor]

Using,

    "@commitlint/cli": "^5.0.0",
    "@commitlint/config-angular": "^5.0.0",

with standard version, fails with:

husky > npm run -s commitmsg (node v8.4.0)

⧗   input: chore(release): 1.0.0
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖   type must be one of [build, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
✖   found 2 problems, 0 warnings

husky > commit-msg hook failed (add --no-verify to bypass)

Command failed: git commit CHANGELOG.md package.json package-lock.json -m "chore(release): 1.0.0"
husky > npm run -s precommit (node v8.4.0)

Running tasks for *.js [started]
Running tasks for *.js [skipped]
→ No staged files match *.js
husky > npm run -s commitmsg (node v8.4.0)

⧗   input: chore(release): 1.0.0
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖   type must be one of [build, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
✖   found 2 problems, 0 warnings

Perhaps the type and message need to be adjusted?

//cc @marionebl @bcoe

[satazor]

@marionebl I think that the valid types on @commitlint/config-angular are wrong.

Valid types are: feat:, fix, docs, style, refactor, perf, test and chore. Basically chore is missing and build, ci and revert should not be allowed. See https://github.com/marionebl/commitlint/pull/143

Regarding the subject, according to angular guidelines it must start with a verb. Changing to release %s should do it.

[marionebl]

This is caused by commitlint switching to the new Angular (vs. Angular.js) commit conventions with version 5.0.0.

I think we should update standard-version to match the latest conventions.

You can fall back to @commitlint/config-angular@4 until that lands.

[bcoe]

@satazor see my comments on #220

I'm not too excited to drop the chore commit type -- personally I'd rather introduce a new commit convention for standard-version that tracks https://conventionalcommits.org/ (which it sounds like is looser than angular's convention now, since it allows you to use arbitrary verbs).

Edit:

Having calmed down from my initial annoyance at the angular spec being made tighter, I'm onboard with making our commits adhere to their new format. At the same time, I would like to set a goal of moving this project towards a @commitlint/conventional-commits format.

[satazor]

@bcoe I share the same concerns actually. I think that we should really create a more simpler standard because the new one has some new types that are kind of specific to their needs (e.g.: build vs chore, style..) and introduce unnecessary complexity when deciding.

Since commitlint updates their last tag back to 4 this no longer is a emergency and we have time to decide.

[bcoe]

@satazor see conversation here, @marionebl has done a great job of outlining some of the work that we'd need to take on to simplify the commit conventions.