Skip to content

Commit 1eba511

Browse files
andrasbacsaiclaude
andcommitted
fix: use assert instead of require in HTTP handlers
Replace require.NoError with assert.NoError inside HTTP handler functions to fix testifylint go-require violations. Using require in HTTP handlers can cause unpredictable test behavior since t.FailNow() only exits the current goroutine (the handler), not the main test goroutine. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 541f633 commit 1eba511

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

internal/service/application_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -956,7 +956,7 @@ func TestApplicationService_CreatePublic(t *testing.T) {
956956

957957
var req models.ApplicationCreatePublicRequest
958958
err := json.NewDecoder(r.Body).Decode(&req)
959-
require.NoError(t, err)
959+
assert.NoError(t, err)
960960
assert.Equal(t, "proj-uuid", req.ProjectUUID)
961961
assert.Equal(t, "server-uuid", req.ServerUUID)
962962
assert.Equal(t, "https://github.com/user/repo", req.GitRepository)
@@ -1034,7 +1034,7 @@ func TestApplicationService_CreateGitHubApp(t *testing.T) {
10341034

10351035
var req models.ApplicationCreateGitHubAppRequest
10361036
err := json.NewDecoder(r.Body).Decode(&req)
1037-
require.NoError(t, err)
1037+
assert.NoError(t, err)
10381038
assert.Equal(t, "github-app-uuid", req.GitHubAppUUID)
10391039
assert.Equal(t, "owner/repo", req.GitRepository)
10401040

@@ -1079,7 +1079,7 @@ func TestApplicationService_CreateDeployKey(t *testing.T) {
10791079

10801080
var req models.ApplicationCreateDeployKeyRequest
10811081
err := json.NewDecoder(r.Body).Decode(&req)
1082-
require.NoError(t, err)
1082+
assert.NoError(t, err)
10831083
assert.Equal(t, "key-uuid", req.PrivateKeyUUID)
10841084
assert.Equal(t, "git@github.com:owner/repo.git", req.GitRepository)
10851085

@@ -1124,7 +1124,7 @@ func TestApplicationService_CreateDockerfile(t *testing.T) {
11241124

11251125
var req models.ApplicationCreateDockerfileRequest
11261126
err := json.NewDecoder(r.Body).Decode(&req)
1127-
require.NoError(t, err)
1127+
assert.NoError(t, err)
11281128
assert.Contains(t, req.Dockerfile, "FROM node:18")
11291129

11301130
app := models.Application{
@@ -1162,7 +1162,7 @@ func TestApplicationService_CreateDockerImage(t *testing.T) {
11621162

11631163
var req models.ApplicationCreateDockerImageRequest
11641164
err := json.NewDecoder(r.Body).Decode(&req)
1165-
require.NoError(t, err)
1165+
assert.NoError(t, err)
11661166
assert.Equal(t, "nginx:latest", req.DockerRegistryImageName)
11671167
assert.Equal(t, "80", req.PortsExposes)
11681168

internal/service/project_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func TestProjectService_Create(t *testing.T) {
8989

9090
var req models.ProjectCreateRequest
9191
err := json.NewDecoder(r.Body).Decode(&req)
92-
require.NoError(t, err)
92+
assert.NoError(t, err)
9393
assert.Equal(t, "New Project", req.Name)
9494
assert.NotNil(t, req.Description)
9595
assert.Equal(t, "New Project Description", *req.Description)
@@ -123,7 +123,7 @@ func TestProjectService_Create_NameOnly(t *testing.T) {
123123

124124
var req models.ProjectCreateRequest
125125
err := json.NewDecoder(r.Body).Decode(&req)
126-
require.NoError(t, err)
126+
assert.NoError(t, err)
127127
assert.Equal(t, "Minimal Project", req.Name)
128128
assert.Nil(t, req.Description)
129129

0 commit comments

Comments
 (0)