[FIX] fix and improve multiple things

* replace the donation.donation.pos_payment_ids field by
  pos_payment_method_ids to be able to access the pos payment methods
  directly.
* fix donation creation error: the code was trying to store
  pos.payment.method ids in a many2many to pos.payment.
* make donation.donation.pos_payment_method_ids a computed field.
* avoid error in pos if no partner is selected.
* remove useless code.
* rename "POS" to "PoS" in multiple places.
* update i18n files.
* update readme.

Author: huguesdk

pos_donation/README.rst

@@ -1,5 +1,5 @@
 ============
-POS Donation
+PoS Donation
 ============
 
 .. 
@@ -28,15 +28,31 @@ POS Donation
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
-When a donation product is sold in the POS, this module creates a
-donation related to the POS Order in draft state. This donation can be
-validated in order to generate a tax receipt for this donation.
+When a donation product is sold in the PoS, this module creates a donation related to the PoS order and validates it.
 
 **Table of contents**
 
 .. contents::
    :local:
 
+Usage
+=====
+
+To create donations from the PoS, a donation product must be sold.
+This product must have the "Donation in PoS" product type.
+This is important: the normal "Donation" product type will not work, as this would generate accounting entries two times.
+
+The price of the product on the PoS order line defines the price of the donation.
+
+Known issues / Roadmap
+======================
+
+* If there is no partner set on the PoS order, a donation is not created.
+  There should be a user warning in the PoS to avoid this.
+* If there are multiple donation products used in the same PoS order, a donation is not created.
+  This is because the ``default_tax_receipt_option`` is currently defined on the ``product.template``.
+  It would be better to define it on on a more global record, like the ``pos.config``.
+
 Bug Tracker
 ===========
 

pos_donation/__manifest__.py

@@ -3,10 +3,10 @@
 # SPDX-License-Identifier: AGPL-3.0-or-later
 
 {
-    "name": "POS Donation",
-    "summary": "Generate donation for donation sold in POS.",
+    "name": "PoS Donation",
+    "summary": "Generate donation for donation sold in PoS",
     "version": "16.0.1.0.0",
-    "category": "POS",
+    "category": "Sales/Point of Sale",
     "website": "https://github.com/OCA/pos",
     "author": "Coop IT Easy SC, Odoo Community Association (OCA)",
     "maintainers": ["remytms"],

pos_donation/demo/donation.xml

@@ -5,12 +5,14 @@
         <field name="default_code">POS-DON</field>
         <field name="categ_id" ref="product.product_category_5" />
         <field name="sale_ok" eval="True" />
-        <field name="tax_receipt_ok" eval="True" />
         <field name="list_price">0</field>
-        <field name="detailed_type">donation_in_pos</field>
         <field name="taxes_id" eval="False" />
+        <field name="detailed_type">donation_in_pos</field>
+        <field name="tax_receipt_ok" eval="True" />
+        <field name="available_in_pos">True</field>
+        <field name="default_tax_receipt_option">none</field>
         <field
             name="description"
-        >This donation item that can be sold in POS and is eligible for a tax receipt.</field>
+        >Donation item that can be sold in PoS and that is eligible for a tax receipt</field>
     </record>
 </odoo>

pos_donation/i18n/fr.po

@@ -10,6 +10,7 @@ msgstr ""
 "PO-Revision-Date: 2025-07-13 07:27+0000\n"
 "Last-Translator: Simon Hick\n"
 "Language-Team: \n"
+"Language: fr\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: \n"
@@ -19,7 +20,8 @@ msgstr ""
 #: model:ir.model.fields,help:pos_donation.field_product_product__detailed_type
 #: model:ir.model.fields,help:pos_donation.field_product_template__detailed_type
 msgid ""
-"A storable product is a product for which you manage stock. The Inventory app has to be installed.\n"
+"A storable product is a product for which you manage stock. The Inventory "
+"app has to be installed.\n"
 "A consumable product is a product for which stock is not managed.\n"
 "A service is a non-material product you provide."
 msgstr ""
@@ -47,9 +49,16 @@ msgstr ""
 
 #. module: pos_donation
 #: model:ir.model.fields.selection,name:pos_donation.selection__product_template__detailed_type__donation_in_pos
-msgid "Donation in POS"
+msgid "Donation in PoS"
 msgstr ""
 
+#. module: pos_donation
+#: model_terms:product.template,description:pos_donation.product_product_donation_pos_product_template
+msgid ""
+"Donation item that can be sold in PoS and that is eligible for a tax receipt"
+msgstr ""
+"Don qui peut être vendu en PdV et qui est éligible pour un reçu fiscal"
+
 #. module: pos_donation
 #: model:ir.model.fields.selection,name:pos_donation.selection__product_template__default_tax_receipt_option__each
 msgid "For Each Donation"
@@ -60,34 +69,28 @@ msgstr ""
 msgid "None"
 msgstr ""
 
+#. module: pos_donation
+#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__displayed_payment_mode
+msgid "Payment Mode"
+msgstr ""
+
 #. module: pos_donation
 #: model:product.template,name:pos_donation.product_product_donation_pos_product_template
-msgid "POS Donation"
+msgid "PoS Donation"
 msgstr ""
 
 #. module: pos_donation
 #. odoo-python
 #: code:addons/pos_donation/models/donation.py:0
-#: code:addons/pos_donation/models/donation.py:0
-#: code:addons/src/oca/pos/pos_donation/models/donation.py:0
+#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_order_id
 #: model_terms:ir.ui.view,arch_db:pos_donation.donation_form
 #, python-format
-msgid "POS Order"
-msgstr ""
-
-#. module: pos_donation
-#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__displayed_payment_mode
-msgid "Payment Mode"
-msgstr ""
-
-#. module: pos_donation
-#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_order_id
 msgid "PoS Order"
 msgstr ""
 
 #. module: pos_donation
-#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_payment_ids
-msgid "PoS payment methods"
+#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_payment_method_ids
+msgid "PoS Payment Methods"
 msgstr ""
 
 #. module: pos_donation
@@ -106,28 +109,13 @@ msgstr ""
 msgid "Product Type"
 msgstr ""
 
-#. module: pos_donation
-#. odoo-python
-#: code:addons/pos_donation/models/product_template.py:0
-#: code:addons/pos_donation/models/product_template.py:0
-#: code:addons/src/oca/pos/pos_donation/models/product_template.py:0
-#: model:ir.model.constraint,message:pos_donation.constraint_product_template_check_company_id_for_donation_in_pos
-#, python-format
-msgid ""
-"Product for donation in pos must belong to a company."
-msgstr "Un produit représentant une donation doit appartenir à une entreprise"
-
-#. module: pos_donation
-#: model_terms:product.template,description:pos_donation.product_product_donation_pos_product_template
-msgid ""
-"This donation item that can be sold in POS and is eligible for a tax "
-"receipt."
-msgstr "Ce produit est une donation, il peut être vendu en PdV et est éligible "
-"pour un reçu fiscal."
-
 #. module: pos_donation
 #. odoo-python
 #: code:addons/pos_donation/models/donation.py:0
 #, python-format
 msgid "Various"
 msgstr "Divers"
+
+#~ msgid "Product for donation in pos must belong to a company."
+#~ msgstr ""
+#~ "Un produit représentant une donation doit appartenir à une entreprise"

pos_donation/i18n/pos_donation.pot

@@ -6,8 +6,6 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 16.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-07-13 07:26+0000\n"
-"PO-Revision-Date: 2025-07-13 07:26+0000\n"
 "Last-Translator: \n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -47,7 +45,13 @@ msgstr ""
 
 #. module: pos_donation
 #: model:ir.model.fields.selection,name:pos_donation.selection__product_template__detailed_type__donation_in_pos
-msgid "Donation in POS"
+msgid "Donation in PoS"
+msgstr ""
+
+#. module: pos_donation
+#: model_terms:product.template,description:pos_donation.product_product_donation_pos_product_template
+msgid ""
+"Donation item that can be sold in PoS and that is eligible for a tax receipt"
 msgstr ""
 
 #. module: pos_donation
@@ -60,34 +64,28 @@ msgstr ""
 msgid "None"
 msgstr ""
 
+#. module: pos_donation
+#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__displayed_payment_mode
+msgid "Payment Mode"
+msgstr ""
+
 #. module: pos_donation
 #: model:product.template,name:pos_donation.product_product_donation_pos_product_template
-msgid "POS Donation"
+msgid "PoS Donation"
 msgstr ""
 
 #. module: pos_donation
 #. odoo-python
 #: code:addons/pos_donation/models/donation.py:0
-#: code:addons/pos_donation/models/donation.py:0
-#: code:addons/src/oca/pos/pos_donation/models/donation.py:0
+#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_order_id
 #: model_terms:ir.ui.view,arch_db:pos_donation.donation_form
 #, python-format
-msgid "POS Order"
-msgstr ""
-
-#. module: pos_donation
-#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__displayed_payment_mode
-msgid "Payment Mode"
-msgstr ""
-
-#. module: pos_donation
-#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_order_id
 msgid "PoS Order"
 msgstr ""
 
 #. module: pos_donation
-#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_payment_ids
-msgid "PoS payment methods"
+#: model:ir.model.fields,field_description:pos_donation.field_donation_donation__pos_payment_method_ids
+msgid "PoS Payment Methods"
 msgstr ""
 
 #. module: pos_donation
@@ -106,24 +104,6 @@ msgstr ""
 msgid "Product Type"
 msgstr ""
 
-#. module: pos_donation
-#. odoo-python
-#: code:addons/pos_donation/models/product_template.py:0
-#: code:addons/pos_donation/models/product_template.py:0
-#: code:addons/src/oca/pos/pos_donation/models/product_template.py:0
-#: model:ir.model.constraint,message:pos_donation.constraint_product_template_check_company_id_for_donation_in_pos
-#, python-format
-msgid ""
-"Product for donation in pos must belong to a company."
-msgstr ""
-
-#. module: pos_donation
-#: model_terms:product.template,description:pos_donation.product_product_donation_pos_product_template
-msgid ""
-"This donation item that can be sold in POS and is eligible for a tax "
-"receipt."
-msgstr ""
-
 #. module: pos_donation
 #. odoo-python
 #: code:addons/pos_donation/models/donation.py:0

pos_donation/models/donation.py

@@ -12,44 +12,43 @@ class DonationDonation(models.Model):
         string="PoS Order",
         comodel_name="pos.order",
     )
-    pos_payment_ids = fields.Many2many(
-        string="PoS payment methods", comodel_name="pos.payment"
+    pos_payment_method_ids = fields.Many2many(
+        "pos.payment.method",
+        string="PoS Payment Methods",
+        compute="_compute_pos_payment_method_ids",
     )
     displayed_payment_mode = fields.Char(
-        string="Payment Mode",
+        # non-breaking space here to avoid warning (because this is done on
+        # purpose): Two fields (displayed_payment_mode, payment_mode_id) of
+        # donation.donation() have the same label: Payment Mode. [Modules:
+        # pos_donation and donation]
+        string="Payment Mode",
         compute="_compute_displayed_payment_mode",
     )
 
-    @api.depends("pos_payment_ids", "payment_mode_id")
+    @api.depends("pos_order_id.payment_ids.payment_method_id")
+    def _compute_pos_payment_method_ids(self):
+        for rec in self:
+            rec.pos_payment_method_ids = rec.pos_order_id.payment_ids.payment_method_id
+
+    @api.depends("pos_order_id.payment_ids.payment_method_id", "payment_mode_id")
     def _compute_displayed_payment_mode(self):
         for donation in self:
-            if len(donation.pos_payment_ids) > 1:
-                donation.displayed_payment_mode = _("Various")
-            elif len(donation.pos_payment_ids) == 1:
-                donation.displayed_payment_mode = (
-                    donation.pos_payment_ids.payment_method_id.name
-                )
+            if donation.pos_payment_method_ids:
+                if len(donation.pos_payment_method_ids) > 1:
+                    donation.displayed_payment_mode = _("Various")
+                else:
+                    donation.displayed_payment_mode = (
+                        donation.pos_payment_method_ids.name
+                    )
             else:
                 donation.displayed_payment_mode = donation.payment_mode_id.name
 
     def action_view_pos_order_id(self):
         return {
             "type": "ir.actions.act_window",
-            "name": _("POS Order"),
+            "name": _("PoS Order"),
             "res_model": "pos.order",
             "view_mode": "tree,form",
-            "domain": [("id", "in", self.pos_order_id.ids)],
+            "domain": [("id", "=", self.pos_order_id.id)],
         }
-
-    def validate(self):
-        """Keep payment_mode_id for donation_in_pos"""
-        payment_modes = {}
-        for donation in self:
-            payment_modes[donation.id] = donation.payment_mode_id
-        res = super().validate()
-        for donation in self:
-            if "donation_in_pos" in donation.line_ids.product_id.mapped(
-                "detailed_type"
-            ):
-                donation.payment_mode_id = payment_modes[donation.id]
-        return res

pos_donation/models/donation_line.py

@@ -9,9 +9,9 @@ class DonationLine(models.Model):
     _inherit = "donation.line"
 
     def _compute_in_kind(self):
-        """Donation in POS should be considered as donation in-kind.
+        """Donation in PoS should be considered as donation in-kind.
         These donation should not generate account move,
-        because account move has already been generated by the POS.
+        because account move has already been generated by the PoS.
         """
         res = super()._compute_in_kind()
         for line in self: