review

Author: UnelDev

Models/Caller.ts

@@ -36,7 +36,7 @@ const CallerSchema = new mongoose.Schema({
 	},
 	createdAt: {
 		type: Date,
-		default: new Date()
+		default: Date.now
 	}
 });
 

Models/Campaign.ts

@@ -26,7 +26,7 @@ const CampaignSchema = new mongoose.Schema({
 	},
 	createdAt: {
 		type: Date,
-		default: Date.now()
+		default: Date.now
 	},
 	password: {
 		type: String,

Models/Client.ts

@@ -41,15 +41,15 @@ const ClientSchema = new mongoose.Schema({
 	},
 	firstIntegration: {
 		type: Date,
-		default: Date.now()
+		default: Date.now
 	},
 	integrationReason: {
 		type: String,
 		default: 'unknown'
 	},
 	createdAt: {
 		type: Date,
-		default: Date.now()
+		default: Date.now
 	}
 });
 

router/admin/client/createClient.ts

@@ -160,7 +160,7 @@ export default async function createClient(req: Request<any>, res: Response<any>
 		}
 	} else {
 		client = new Client({
-			name: sanitizeString(req.body.name) ?? 'unknown',
+			name: sanitizeString(req.body.name || 'unknown'),
 			phone: phone,
 			firstname: sanitizeString(req.body.firstName ?? ''),
 			institution: sanitizeString(req.body.institution ?? ''),

router/admin/client/createClients.ts

@@ -63,7 +63,7 @@ export default async function createClients(req: Request<any>, res: Response<any
 			(usr.firstname === undefined || typeof usr.firstname === 'string') &&
 			(usr.institution === undefined || typeof usr.institution === 'string') &&
 			(usr.priority === undefined || typeof usr.priority === 'string') &&
-			(usr.firstIntegration === undefined || !isNaN(parseInt(usr.firstIntegration))) &&
+			(usr.firstIntegration === undefined || !isNaN(new Date(usr.firstIntegration).getTime())) &&
 			(usr.integrationReason === undefined || typeof usr.integrationReason === 'string')
 		);
 	});
@@ -147,8 +147,7 @@ export default async function createClients(req: Request<any>, res: Response<any
 								const date = new Date(usr.firstIntegration || '');
 								return isNaN(date.getTime()) ? Date.now() : date.getTime();
 							})(),
-							integrationReason:
-								sanitizeString(usr.integrationReason || '') ?? sanitizeString(req.body.defaultReason)
+							integrationReason: sanitizeString(usr.integrationReason || req.body.defaultReason || '')
 						},
 						{ $push: { campaigns: campaign._id } }
 					);
@@ -165,13 +164,12 @@ export default async function createClients(req: Request<any>, res: Response<any
 								const date = new Date(usr.firstIntegration || '');
 								return isNaN(date.getTime()) ? Date.now() : date.getTime();
 							})(),
-							integrationReason:
-								sanitizeString(usr.integrationReason || '') ?? sanitizeString(req.body.defaultReason)
+							integrationReason: sanitizeString(usr.integrationReason || req.body.defaultReason || '')
 						}
 					);
 				}
 			} catch (error: any) {
-				errors.push([usr.name || '' + ' ' + usr.firstname || '', phone, error.message]);
+				errors.push([(usr.name || '') + ' ' + (usr.firstname || ''), phone, error.message]);
 			}
 		}
 	);

router/caller/getPhoneNumber.ts

@@ -114,6 +114,7 @@ export default async function getPhoneNumber(req: Request<any>, res: Response<an
 		if (!client) {
 			res.status(404).send({ message: 'Client not found', OK: false });
 			log(`[${req.body.phone}, ${ip}] Client not found`, 'WARNING', __filename);
+			return;
 		}
 
 		res.status(200).send({

tools/utils.ts

@@ -111,8 +111,8 @@ function cleanStatus(status: 'In progress' | 'to recall' | 'Done' | 'deleted' |
  * @param str - The string to be sanitized.
  * @returns The sanitized string with leading and trailing whitespace removed.
  */
-function sanitizeString(str: string) {
-	str = str.replace(/[{,},$]/gm, '');
+function sanitizeString(str?: string) {
+	str = str?.replace(/[{,},$]/gm, '') ?? '';
 	return str.trim();
 }
 
@@ -205,7 +205,7 @@ function checkParameters(
 			// 	});
 			// 	log(`[${ip}] ` + errorText, 'WARNING', orgin);
 			// 	return false;
-		} else if (parameter[1] == 'Date' && !isNaN(new Date(body[parameter[0]]).getTime())) {
+		} else if (parameter[1] == 'Date' && isNaN(new Date(body[parameter[0]]).getTime())) {
 			res.status(400).send({
 				message: errorText,
 				OK: false