Fixed Bug 2178: During compile of COptItem a missing number was accessed for comparison.

Stefan Hoops · Stefan Hoops · commit 49d1f56dc960 · 2015-07-15T16:23:51.000-04:00
diff --git a/copasi/optimization/COptItem.cpp b/copasi/optimization/COptItem.cpp
@@ -386,7 +386,8 @@ bool COptItem::compile(const std::vector< CCopasiContainer * > listOfContainer)
       success = false;
     }
 
-  if (!mpUpperObject && !mpLowerObject && *mpUpperBound < *mpLowerBound)
+  // We can only access the lower and upper numbers if the compile succeeded so far.
+  if (success && !mpUpperObject && !mpLowerObject && *mpUpperBound < *mpLowerBound)
     {
       CCopasiMessage(CCopasiMessage::ERROR, MCOptimization + 4, *mpLowerBound, *mpUpperBound, mpObject->getObjectDisplayName().c_str());
       success = false;

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,8 @@ bool COptItem::compile(const std::vector< CCopasiContainer * > listOfContainer)`
`386`	`386`	`success = false;`
`387`	`387`	`}`
`388`	`388`
`389`		`- if (!mpUpperObject && !mpLowerObject && mpUpperBound < mpLowerBound)`
	`389`	`+ // We can only access the lower and upper numbers if the compile succeeded so far.`
	`390`	`+ if (success && !mpUpperObject && !mpLowerObject && mpUpperBound < mpLowerBound)`
`390`	`391`	`{`
`391`	`392`	`CCopasiMessage(CCopasiMessage::ERROR, MCOptimization + 4, mpLowerBound, mpUpperBound, mpObject->getObjectDisplayName().c_str());`
`392`	`393`	`success = false;`