Skip to content

Commit 2659a25

Browse files
Kannaiyan NatesanKannaiyan Natesan
authored andcommitted
feat(passkeys_doctor): widen package_info_plus to >=9.0.0 <11.0.0
Closes #240. Bumps passkeys_doctor 1.3.1 → 1.4.0 with `package_info_plus` constraint widened from `^9.0.0` to `>=9.0.0 <11.0.0`. The only call site is `_getBundleId` in `lib/src/passkeys_doctor.dart`, which reads `PackageInfo.fromPlatform().packageName`. That getter is API-stable across the 9 → 10 bump — the 10.0.0 breaking changes are entirely in the Windows platform implementation (move to a win32-6 method channel) and do not affect the public API. Why this matters: package_info_plus 9 depends on `win32 ^5.5.3`, while every other plugin that has bumped recently (share_plus 13, flutter_secure_storage_windows 4.2.x, plus the `win32 6.2.0` release itself) depends on `win32 ^6.0.1`. With passkeys_doctor pinned to pip ^9 the entire downstream chain is held back on win32 5, which blocks Windows desktop apps from picking up `CryptProtectData` / `LocalFree` typing fixes that landed in win32 6. Verified locally: - `flutter pub get` resolves cleanly, now pulls in `win32 6.2.0` - `flutter analyze` passes (no issues found) CHANGELOG entry added under 1.4.0. The parent `passkeys` package already accepts `passkeys_doctor: ^1.3.0` (i.e. <2.0.0), so no version bump is required there once 1.4.0 ships to pub.
1 parent dd97792 commit 2659a25

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

packages/passkeys/passkeys_doctor/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.4.0
2+
3+
* Widens `package_info_plus` constraint to `>=9.0.0 <11.0.0` to unblock consumers on `package_info_plus` 10.x. The only call site (`PackageInfo.fromPlatform().packageName`) is API-stable across the 9 → 10 bump. Unblocks downstream apps that need `share_plus 13.x` / `win32 ^6.0.1`. See https://github.com/corbado/flutter-passkeys/issues/240.
4+
15
## 1.3.1
26

37
* Widens `device_info_plus` constraint to `>=11.2.0 <14.0.0` to unblock consumers on `device_info_plus` 12.x.

packages/passkeys/passkeys_doctor/pubspec.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: passkeys_doctor
22
description: "Internal debugging tools used to help with passkeys package."
33
homepage: https://docs.corbado.com/overview/welcome
44
repository: https://github.com/corbado/flutter-passkeys/tree/main/packages/passkeys/passkeys_doctor
5-
version: 1.3.1
5+
version: 1.4.0
66

77
environment:
88
sdk: ">=3.0.0 <4.0.0"
@@ -13,7 +13,14 @@ dependencies:
1313
sdk: flutter
1414
http: ^1.3.0
1515
device_info_plus: ">=11.2.0 <14.0.0"
16-
package_info_plus: ^9.0.0
16+
# Widened from ^9.0.0 to allow ^10.0.0 too. The only call site
17+
# (`PackageInfo.fromPlatform().packageName` in
18+
# `lib/src/passkeys_doctor.dart::_getBundleId`) is API-stable
19+
# across the 9 → 10 bump. Keeping the lower bound at 9.0.0 so
20+
# existing consumers on package_info_plus 9.x are not forced to
21+
# upgrade. See https://github.com/corbado/flutter-passkeys/issues/240
22+
# for the downstream win32-6 chain this unblocks.
23+
package_info_plus: ">=9.0.0 <11.0.0"
1724
passkeys_platform_interface: ^2.4.0
1825
passkeys_ios: ^2.6.1
1926

0 commit comments

Comments
 (0)