Skip to content

Commit 095539c

Browse files
gmarullclaude
andcommitted
ci: drop configure-aws-credentials for log hash upload
The configure-aws-credentials action always validates credentials via an STS GetCallerIdentity call, which fails ("The security token included in the request is invalid.") because the log hash bucket is a non-AWS S3-compatible endpoint, not real AWS. There is no option to skip that validation. Drop the action and pass the credentials directly to the existing aws s3 cp step via environment variables, restoring the behavior of the previous Noelware/s3-action (raw S3 API against a custom endpoint, no STS). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
1 parent b7bed6d commit 095539c

3 files changed

Lines changed: 16 additions & 31 deletions

File tree

.github/workflows/build-firmware.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,12 @@ jobs:
9393
run: |
9494
echo "BUILD_ID=$(readelf -n build/src/fw/tintin_fw.elf | sed -n -e 's/^.*Build ID: //p')" >> "$GITHUB_OUTPUT"
9595
96-
- name: Configure AWS credentials
97-
if: ${{ github.event_name == 'push' && github.repository == 'coredevices/PebbleOS' }}
98-
uses: aws-actions/configure-aws-credentials@v6
99-
with:
100-
aws-access-key-id: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
101-
aws-secret-access-key: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
102-
aws-region: us-east-1
103-
10496
- name: Upload log hash dictionary
10597
if: ${{ github.event_name == 'push' && github.repository == 'coredevices/PebbleOS' }}
98+
env:
99+
AWS_ACCESS_KEY_ID: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
100+
AWS_SECRET_ACCESS_KEY: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
101+
AWS_DEFAULT_REGION: us-east-1
106102
run: |
107103
pip install awscli
108104
aws s3 cp build/src/fw/tintin_fw_loghash_dict.json \

.github/workflows/build-prf.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,12 @@ jobs:
9999
run: |
100100
echo "BUILD_ID=$(readelf -n build/src/fw/tintin_fw.elf | sed -n -e 's/^.*Build ID: //p')" >> "$GITHUB_OUTPUT"
101101
102-
- name: Configure AWS credentials
103-
if: ${{ github.event_name == 'push' && github.repository == 'coredevices/PebbleOS' }}
104-
uses: aws-actions/configure-aws-credentials@v6
105-
with:
106-
aws-access-key-id: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
107-
aws-secret-access-key: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
108-
aws-region: us-east-1
109-
110102
- name: Upload log hash dictionary
111103
if: ${{ github.event_name == 'push' && github.repository == 'coredevices/PebbleOS' }}
104+
env:
105+
AWS_ACCESS_KEY_ID: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
106+
AWS_SECRET_ACCESS_KEY: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
107+
AWS_DEFAULT_REGION: us-east-1
112108
run: |
113109
pip install awscli
114110
aws s3 cp build/src/fw/tintin_fw_loghash_dict.json \

.github/workflows/release.yml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,11 @@ jobs:
6767
run: |
6868
echo "BUILD_ID=$(readelf -n build/src/fw/tintin_fw.elf | sed -n -e 's/^.*Build ID: //p')" >> "$GITHUB_OUTPUT"
6969
70-
- name: Configure AWS credentials
71-
uses: aws-actions/configure-aws-credentials@v6
72-
with:
73-
aws-access-key-id: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
74-
aws-secret-access-key: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
75-
aws-region: us-east-1
76-
7770
- name: Upload PRF log hash dictionary
71+
env:
72+
AWS_ACCESS_KEY_ID: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
73+
AWS_SECRET_ACCESS_KEY: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
74+
AWS_DEFAULT_REGION: us-east-1
7875
run: |
7976
pip install awscli
8077
aws s3 cp build/src/fw/tintin_fw_loghash_dict.json \
@@ -181,16 +178,12 @@ jobs:
181178
run: |
182179
echo "BUILD_ID=$(readelf -n build/src/fw/tintin_fw.elf | sed -n -e 's/^.*Build ID: //p')" >> "$GITHUB_OUTPUT"
183180
184-
- name: Configure AWS credentials
185-
if: ${{ github.repository == 'coredevices/PebbleOS' }}
186-
uses: aws-actions/configure-aws-credentials@v6
187-
with:
188-
aws-access-key-id: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
189-
aws-secret-access-key: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
190-
aws-region: us-east-1
191-
192181
- name: Upload log hash dictionary
193182
if: ${{ github.repository == 'coredevices/PebbleOS' }}
183+
env:
184+
AWS_ACCESS_KEY_ID: ${{ secrets.LOG_HASH_BUCKET_KEY_ID }}
185+
AWS_SECRET_ACCESS_KEY: ${{ secrets.LOG_HASH_BUCKET_SECRET }}
186+
AWS_DEFAULT_REGION: us-east-1
194187
run: |
195188
pip install awscli
196189
aws s3 cp build/src/fw/tintin_fw_loghash_dict.json \

0 commit comments

Comments
 (0)