capabilities: Create APP_SCALING capability to enable scaling for fake QEMU targets

Signed-off-by: Liam McLoughlin <lmcloughlin@google.com>

Author: Hexxeh

platform/platform_capabilities.py

@@ -51,7 +51,8 @@
     'HAS_DYNAMIC_BACKLIGHT',
     'HAS_COLOR_BACKLIGHT',
     'HAS_SPEAKER',
-    'HAS_ACCEL_SENSITIVITY'
+    'HAS_ACCEL_SENSITIVITY',
+    'HAS_APP_SCALING',
 }
 
 board_capability_dicts = [
@@ -150,7 +151,8 @@
             'HAS_VIBE_SCORES',
             'USE_PARALLEL_FLASH',
             'HAS_WEATHER',
-            'HAS_PUTBYTES_PREACKING'
+            'HAS_PUTBYTES_PREACKING',
+            'HAS_APP_SCALING'
         }
     },
     {
@@ -226,6 +228,7 @@
             'USE_PARALLEL_FLASH',
             'HAS_WEATHER',
             'HAS_PUTBYTES_PREACKING',
+            'HAS_APP_SCALING'
         },
     },
     {
@@ -296,7 +299,8 @@
             'HAS_TIMELINE_PEEK',
             'HAS_VIBE_SCORES',
             'HAS_WEATHER',
-            'HAS_PUTBYTES_PREACKING'
+            'HAS_PUTBYTES_PREACKING',
+            'HAS_APP_SCALING'
         }
     },
     {
@@ -321,7 +325,8 @@
             'HAS_VIBE_SCORES',
             'HAS_WEATHER',
             'HAS_PUTBYTES_PREACKING',
-            'HAS_TOUCHSCREEN'
+            'HAS_TOUCHSCREEN',
+            'HAS_APP_SCALING'
         }
     },
     {
@@ -378,6 +383,7 @@
             'HAS_COLOR_BACKLIGHT',
             'HAS_SPEAKER',
             'HAS_ACCEL_SENSITIVITY',
+            'HAS_APP_SCALING'
         },
     },
     {
@@ -404,6 +410,7 @@
             'HAS_MAGNETOMETER',
             'HAS_PBLBOOT',
             'HAS_ACCEL_SENSITIVITY',
+            'HAS_APP_SCALING'
         },
     },
 ]

src/fw/apps/system_apps/settings/settings_display.c

@@ -164,7 +164,7 @@ static void prv_timeout_menu_push(SettingsDisplayData *data) {
 
 // Legacy App Mode Settings (Obelix only)
 /////////////////////////////
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
 static const char *s_legacy_app_mode_labels[] = {
     i18n_noop("Centered"),
     i18n_noop("Scaled")
@@ -207,7 +207,7 @@ enum SettingsDisplayItem {
 #if PLATFORM_SPALDING && !PLATFORM_SPALDING_GABBRO
   SettingsDisplayAdjustAlignment,
 #endif
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
   SettingsDisplayLegacyAppMode,
 #endif
   NumSettingsDisplayItems
@@ -265,7 +265,7 @@ static void prv_select_click_cb(SettingsCallbacks *context, uint16_t row) {
       settings_display_calibration_push(app_state_get_window_stack());
       break;
 #endif
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
     case SettingsDisplayLegacyAppMode:
       prv_legacy_app_mode_menu_push(data);
       break;
@@ -365,7 +365,7 @@ static void prv_draw_row_cb(SettingsCallbacks *context, GContext *ctx,
       title = i18n_noop("Screen Alignment");
       break;
 #endif
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
     case SettingsDisplayLegacyAppMode:
       title = i18n_noop("Legacy Apps");
       subtitle = (shell_prefs_get_legacy_app_render_mode() == LegacyAppRenderMode_Scaling) ?

src/fw/services/common/compositor/compositor.c

@@ -176,7 +176,7 @@ void compositor_render_app(void) {
     const int16_t disp_width = DISP_COLS;
     const int16_t disp_height = DISP_ROWS;
 
-#if (PLATFORM_OBELIX || PLATFORM_GETAFIX) && !RECOVERY_FW
+#if (CAPABILITY_HAS_APP_SCALING) && !RECOVERY_FW
     // Check if we should use scaling mode for legacy apps
     if (shell_prefs_get_legacy_app_render_mode() == LegacyAppRenderMode_Scaling) {
       // Scale legacy apps to fill the display using nearest-neighbor scaling

src/fw/shell/normal/prefs.c

@@ -209,11 +209,11 @@ static uint16_t s_timeline_peek_before_time_m =
 #endif
 
 #define PREF_KEY_COREDUMP_ON_REQUEST "coredumpOnRequest"
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
 #define PREF_KEY_LEGACY_APP_RENDER_MODE "legacyAppRenderMode"
 #endif
 static bool s_coredump_on_request_enabled = false;
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
 static uint8_t s_legacy_app_render_mode = 1; // Default to scaled mode
 #endif
 
@@ -588,7 +588,7 @@ static bool prv_set_s_coredump_on_request_enabled(bool *enabled) {
   return true;
 }
 
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
 static bool prv_set_s_legacy_app_render_mode(uint8_t *mode) {
   if (*mode >= LegacyAppRenderModeCount) {
     return false;  // Invalid value
@@ -1546,7 +1546,7 @@ void shell_prefs_set_coredump_on_request(bool enabled) {
   prv_pref_set(PREF_KEY_COREDUMP_ON_REQUEST, &enabled, sizeof(enabled));
 }
 
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
 LegacyAppRenderMode shell_prefs_get_legacy_app_render_mode(void) {
   return (LegacyAppRenderMode)s_legacy_app_render_mode;
 }

src/fw/shell/normal/prefs_values.h.inc

@@ -51,7 +51,7 @@
   PREFS_MACRO(PREF_KEY_TIMELINE_PEEK_BEFORE_TIME_M, s_timeline_peek_before_time_m)
 #endif
   PREFS_MACRO(PREF_KEY_COREDUMP_ON_REQUEST, s_coredump_on_request_enabled)
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX
+#if CAPABILITY_HAS_APP_SCALING
   PREFS_MACRO(PREF_KEY_LEGACY_APP_RENDER_MODE, s_legacy_app_render_mode)
 #endif
 

src/fw/shell/prefs.h

@@ -127,7 +127,7 @@ uint16_t timeline_peek_prefs_get_before_time(void);
 bool shell_prefs_can_coredump_on_request(void);
 void shell_prefs_set_coredump_on_request(bool enabled);
 
-#if PLATFORM_OBELIX || PLATFORM_GETAFIX || PLATFORM_SNOWY_EMERY || PLATFORM_SPALDING_GABBRO
+#if CAPABILITY_HAS_APP_SCALING
 // Legacy app rendering mode - whether to use bezel or scaling for legacy apps
 typedef enum LegacyAppRenderMode {
   LegacyAppRenderMode_Bezel = 0,    // Center with black bezel (original behavior)

src/fw/shell/sdk/prefs.c

@@ -29,6 +29,11 @@ _Static_assert(sizeof(PreferredContentSize) == sizeof(s_content_size),
                "sizeof(PreferredContentSize) grew, pref needs to be migrated!");
 #endif
 
+#if CAPABILITY_HAS_APP_SCALING
+#define PREF_KEY_LEGACY_APP_RENDER_MODE "legacyAppRenderMode"
+static uint8_t s_legacy_app_render_mode = 1; // Default to scaled mode
+#endif
+
 void shell_prefs_init(void) {
   s_mutex = mutex_create();
   mutex_lock(s_mutex);
@@ -280,3 +285,14 @@ GColor shell_prefs_get_apps_menu_highlight_color(void) {
 void shell_prefs_set_apps_menu_highlight_color(GColor color) {
   // Not used in SDK shell
 }
+
+#if CAPABILITY_HAS_APP_SCALING
+LegacyAppRenderMode shell_prefs_get_legacy_app_render_mode(void) {
+  return (LegacyAppRenderMode)s_legacy_app_render_mode;
+}
+
+void shell_prefs_set_legacy_app_render_mode(LegacyAppRenderMode mode) {
+  uint8_t mode_value = (uint8_t)mode;
+  prv_pref_set(PREF_KEY_LEGACY_APP_RENDER_MODE, &mode_value, sizeof(mode_value));
+}
+#endif