Skip to content

Commit 701da6e

Browse files
authored
Use image tag from chart.yaml by default (#106)
Signed-off-by: Hagai Barel <hagaibarel@gmail.com>
1 parent 4a1c6d4 commit 701da6e

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

charts/coredns/Chart.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: v2
22
name: coredns
3-
version: 1.19.10
3+
version: 1.20.0
44
appVersion: 1.9.4
55
home: https://coredns.io
66
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -14,8 +14,14 @@ sources:
1414
maintainers:
1515
- name: mrueg
1616
- name: haad
17+
- name: HagaiBarel
1718
engine: gotpl
1819
type: application
1920
annotations:
2021
artifacthub.io/changes: |
21-
- Initial helm chart changelog
22+
- kind: changed
23+
description: Use chart appVersion as default image tag
24+
- kind: added
25+
description: Add HagaiBarel as chart maintainer
26+
- kind: fixed
27+
description: Fix reference link to values file in the readme

charts/coredns/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ Alternatively, a YAML file that specifies the values for the above parameters ca
154154
$ helm install coredns coredns/coredns -f values.yaml
155155
```
156156

157-
> **Tip**: You can use the default [values.yaml](values.yaml)
157+
> **Tip**: You can use the default [values.yaml](/charts/coredns/values.yaml)
158158
159159
## Caveats
160160

charts/coredns/templates/deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ spec:
9292
{{- end }}
9393
containers:
9494
- name: "coredns"
95-
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
95+
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
9696
imagePullPolicy: {{ .Values.image.pullPolicy }}
9797
args: [ "-conf", "/etc/coredns/Corefile" ]
9898
volumeMounts:

charts/coredns/values.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44

55
image:
66
repository: coredns/coredns
7-
tag: "1.9.4"
7+
# Overrides the image tag whose default is the chart appVersion.
8+
tag: ""
89
pullPolicy: IfNotPresent
910
## Optionally specify an array of imagePullSecrets.
1011
## Secrets must be manually created in the namespace.

0 commit comments

Comments
 (0)