Merge pull request #202 from martinohmann/image-pull-secrets

fix: align imagePullSecrets in Deployment and ServiceAccount

Author: hagaibarel

charts/coredns/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v2
 name: coredns
-version: 1.39.0
+version: 1.39.1
 appVersion: 1.12.0
 home: https://coredns.io
 icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -19,5 +19,5 @@ maintainers:
 type: application
 annotations:
   artifacthub.io/changes: |
-    - kind: changed
-      description: Upgrade to CoreDNS 1.12.0
+    - kind: fixed
+      description: align imagePullSecrets in Deployment and ServiceAccount

charts/coredns/templates/deployment-autoscaler.yaml

@@ -60,7 +60,7 @@ spec:
       nodeSelector:
 {{ toYaml .Values.autoscaler.nodeSelector | indent 8 }}
       {{- end }}
-      {{- if not (empty .Values.autoscaler.image.pullSecrets) }}
+      {{- if .Values.autoscaler.image.pullSecrets }}
       imagePullSecrets:
 {{ toYaml .Values.autoscaler.image.pullSecrets | indent 8 }}
       {{- end }}

charts/coredns/templates/deployment.yaml

@@ -88,7 +88,7 @@ spec:
       nodeSelector:
 {{ toYaml .Values.nodeSelector | indent 8 }}
       {{- end }}
-      {{- if not (empty .Values.image.pullSecrets) }}
+      {{- if .Values.image.pullSecrets }}
       imagePullSecrets:
 {{ toYaml .Values.image.pullSecrets | indent 8 }}
       {{- end }}

charts/coredns/templates/serviceaccount-autoscaler.yaml

@@ -15,8 +15,6 @@ metadata:
 {{- end }}
 {{- if .Values.autoscaler.image.pullSecrets }}
 imagePullSecrets:
-{{- range .Values.autoscaler.image.pullSecrets }}
-  - name: {{ . }}
-{{- end }}
+{{ toYaml .Values.autoscaler.image.pullSecrets | indent 2 }}
 {{- end }}
 {{- end }}

charts/coredns/templates/serviceaccount.yaml

@@ -16,8 +16,6 @@ metadata:
   {{- end }}
 {{- if .Values.image.pullSecrets }}
 imagePullSecrets:
-{{- range .Values.image.pullSecrets }}
-  - name: {{ . }}
-{{- end }}
+{{ toYaml .Values.image.pullSecrets | indent 2 }}
 {{- end }}
 {{- end }}