jobs/release: support triggering build-node-image

We want the ability to trigger build-node-image from the release job
instead of the latter being cron triggered. That way we reduce the
chance of having compose skew when in pre-GA state, and we get fresh
node images soon after the base image is updated.

I had initially made the mechanism more generic, but meh, it didn't seem
worth the complexity. We can always generalize it if another "follow-up
trigger" case shows up.

Author: jlebon

docs/config.yaml

@@ -63,6 +63,9 @@ streams:
       # is equivalent to listing all live artifacts and cloud platforms in
       # `skip_artifacts`.
       skip_disk_images: true
+      # OPTIONAL: make the release job trigger build-node-image for the
+      # following OCP releases once successful
+      build_node_images: ["4.19-9.6"]
     stable:
       type: production
       # OPTIONAL: override cosa image to use for this stream

jobs/build-node-image.Jenkinsfile

@@ -8,7 +8,6 @@ node {
 }
 
 properties([
-    pipelineTriggers([cron('H H * * *')]),
     parameters([
       choice(name: 'RELEASE',
              choices: pipeutils.get_streams_choices(pipecfg, true),

jobs/release.Jenkinsfile

@@ -126,6 +126,7 @@ lock(resource: "release-${params.STREAM}", extra: locks) {
             """)
         }
 
+        def missing_arches = false
         def builtarches = shwrapCapture("""
                           cosa shell -- cat builds/builds.json | \
                               jq -r '.builds | map(select(.id == \"${params.VERSION}\"))[].arches[]'
@@ -135,6 +136,7 @@ lock(resource: "release-${params.STREAM}", extra: locks) {
             if (params.ALLOW_MISSING_ARCHES) {
                 warn("Some requested architectures did not successfully build!")
                 basearches = builtarches.intersect(basearches)
+                missing_arches = true
             } else {
                 echo "ERROR: Some requested architectures did not successfully build"
                 echo "ERROR: Detected built architectures: $builtarches"
@@ -438,6 +440,15 @@ lock(resource: "release-${params.STREAM}", extra: locks) {
                 }
             }
         }
+
+        if (!missing_arches && stream_info['build_node_images']) {
+            for (release in stream_info['build_node_images']) {
+                build job: 'build-node-image', wait: false, parameters: ([
+                    string(name: 'RELEASE', value: release)
+                ])
+            }
+        }
+
         currentBuild.result = 'SUCCESS'
         currentBuild.description = "${build_description} ✓"