Skip to content

Log the entire body if non-OK fills up disk quickly #306

Open
@jqmichael

Description

@jqmichael

If OIDC page return non-OK status, the current behavior would log the body, which may fill up the disk if it's large enough.

https://github.com/coreos/go-oidc/blob/v3/oidc/oidc.go#L244-L246

Would it be OK not to log the body?

func (p *Provider) UserInfo
       ...
	if resp.StatusCode != http.StatusOK {		
              return nil, fmt.Errorf("%s: %s", resp.Status, body)	
       }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions