Merge pull request #2138 from nikita-dubrovskii/fix_cex_key_removal

luks: fix occasional cex.key file removal

Author: prestist

docs/release-notes.md

@@ -15,7 +15,7 @@ nav_order: 9
 ### Changes
 
 ### Bug fixes
-
+- Fix occasional cex.key file removal
 
 ## Ignition 2.23.0 (2025-09-10)
 

internal/exec/stages/disks/luks.go

@@ -132,11 +132,13 @@ func (s *stage) createLuks(config types.Config) error {
 			if err := keyFile.Close(); err != nil {
 				s.Warning("could not close file %s: %v", keyFilePath, err)
 			}
-			defer func() {
-				if err = os.Remove(keyFilePath); err != nil {
-					s.Warning("could not remove file %s: %v", keyFilePath, err)
+			// We must pass 'keyFilePath' as a parameter here, since it may change below (cex).
+			// Otherwise, the deferred function will see the modified value instead of the original one.
+			defer func(name string) {
+				if removeErr := os.Remove(name); removeErr != nil {
+					s.Warning("could not remove file %s: %v", name, removeErr)
 				}
-			}()
+			}(keyFilePath)
 
 			if luks.Cex.IsPresent() {
 				// each LUKS device has associated keyfiles