tests/types: add configMax version to expand blackbox testing flexability

Add a field which can limit the max version of config generated from blackbox
testing. If left blank blackbox tests will act as they always have. The new
field simply limits the registration of tests to that version number. This
is for the odd case where we want to ensure functionality does not exist when
using older versions of configs.

Author: prestist

tests/register/register.go

@@ -63,6 +63,15 @@ func Register(tType TestType, t types.Test) {
 	if semverErr == nil && version != nil && t.ConfigMinVersion != "" {
 		for _, v := range configVersions[version.Major] {
 			if version.LessThan(v) {
+				// Check if the test is limited to a max version
+				if test.ConfigMaxVersion != "" {
+					maximumVersion, maxVersionSemverErr := semver.NewVersion(test.ConfigMinVersion)
+					// If a valid max version is given and the next deep copy is greater than the max version then we dont register it
+					if maxVersionSemverErr == nil && maximumVersion.LessThan(v) {
+						continue
+					}
+				}
+
 				test = types.DeepCopy(t)
 				test.ReplaceAllVersionVars(v.String())
 				test.ConfigVersion = v.String()

tests/types/types.go

@@ -101,6 +101,7 @@ type Test struct {
 	SystemDirFiles    []File
 	Env               []string // Environment variables for Ignition
 	Config            string
+	ConfigMaxVersion  string
 	ConfigMinVersion  string
 	ConfigVersion     string
 	ConfigShouldBeBad bool // Set to true to skip config validation step