Skip to content

Sync repo templates ⚙#2232

Merged
prestist merged 2 commits into
coreos:mainfrom
coreosbot-releng:repo-templates
Jul 9, 2026
Merged

Sync repo templates ⚙#2232
prestist merged 2 commits into
coreos:mainfrom
coreosbot-releng:repo-templates

Conversation

@coreosbot-releng

@coreosbot-releng coreosbot-releng commented May 20, 2026

Copy link
Copy Markdown

Created by GitHub workflow (source).

Sync with coreos/repo-templates@39d8ae6.

Summary by CodeRabbit

  • Documentation
    • Updated the Fedora release checklist example to reflect the latest branch merge and push steps.
    • Clarified release notes to state that ignition-validate binaries are now signed with the Fedora 44 key.
  • Chores
    • Brought signing-related templates and examples in line with Fedora 44.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Fedora version from 43 to 44 across the release checklist and the signing script. Specifically, it updates the branch references in the issue template and modifies the signing key, version-release suffix, and RPM key in signing-ticket.sh. I have no feedback to provide.

@travier travier added skip-notes This PR does not need release notes and removed skip-notes This PR does not need release notes labels May 20, 2026
@travier

travier commented May 20, 2026

Copy link
Copy Markdown
Member

Needs a release note update as well:

Starting with this release, ignition-validate binaries are signed with the
[Fedora 44 key](https://getfedora.org/security/).

@travier travier enabled auto-merge May 20, 2026 20:43
auto-merge was automatically disabled May 27, 2026 14:12

Head branch was pushed to by a user without write access

@prestist prestist added the skip-notes This PR does not need release notes label Jul 9, 2026
@prestist prestist closed this Jul 9, 2026
@prestist prestist reopened this Jul 9, 2026
@prestist prestist removed the skip-notes This PR does not need release notes label Jul 9, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ce6ebd87-4de5-42d6-8884-850deeb06b1b

📥 Commits

Reviewing files that changed from the base of the PR and between 2bdd043 and 6227b4f.

📒 Files selected for processing (3)
  • .github/ISSUE_TEMPLATE/release-checklist.md
  • docs/release-notes.md
  • signing-ticket.sh

📝 Walkthrough

Walkthrough

Updates the Fedora signing key configuration from Fedora 43 to Fedora 44 in the signing-ticket.sh script, revises the release checklist example branch name from f43 to f44, and adds a release notes entry documenting the Fedora 44 signing key change.

Changes

Fedora 44 migration

Layer / File(s) Summary
Signing key and release process update
signing-ticket.sh, .github/ISSUE_TEMPLATE/release-checklist.md, docs/release-notes.md
Signing script's KEYTOSIGNWITH, VR suffix, and RPMKEY are changed to Fedora 44 values; release checklist example branch updated from f43 to f44; release notes note that ignition-validate binaries are now signed with the Fedora 44 key.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: an automated sync of repository templates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Binary size report (bin/amd64/ignition)

Size
Base (main) 21MiB
PR (#2232) 21MiB
Delta +0B (0.00%)

@prestist prestist enabled auto-merge July 9, 2026 19:16
@prestist prestist merged commit 4360370 into coreos:main Jul 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants