Merge pull request #3028 from aarongerig/patch-3

[IndexBundle] OpenSearchWorker: Refactor delete methods for index operations

Author: dpfaffenbauer

src/CoreShop/Bundle/IndexBundle/Worker/OpenSearchWorker.php

@@ -162,25 +162,31 @@ public function renameIndexStructures(IndexInterface $index, string $oldName, st
      */
     public function deleteFromIndexById(IndexInterface $index, int $id): void
     {
-        $this->getClient($index)
-            ->delete([
-                'index' => $this->getIndexName($index->getName()),
-                'id' => (string) $id,
-            ])
-        ;
+        $client = $this->getClient($index);
+        $indexName = $this->getIndexName($index->getName());
+
+        if (!$client->exists(['index' => $indexName, 'id' => (string) $id])) {
+            return;
+        }
+
+        $client->delete([
+            'index' => $indexName,
+            'id' => (string) $id,
+        ]);
     }
 
     /**
      * @inheritDoc
      */
     public function deleteFromIndex(IndexInterface $index, IndexableInterface $object): void
     {
-        $this->getClient($index)
-            ->delete([
-                'index' => $this->getIndexName($index->getName()),
-                'id' => (string) $object->getId(),
-            ])
-        ;
+        $id = $object->getId();
+
+        if (!is_int($id)) {
+            return;
+        }
+
+        $this->deleteFromIndexById($index, $id);
     }
 
     /**