fix(segmentation): resolve variable declaration and null check issues

* Fixed variable redeclaration in `ensureImageVolume.ts` * Updated null checks in `getStrategyData.ts` to use more robust comparison
cornerstonejs · Mar 4, 2025 · 6644bdb · 6644bdb
1 parent e1b5bc6
commit 6644bdb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/tools/src/tools/segmentation/strategies/compositions/ensureImageVolume.ts b/packages/tools/src/tools/segmentation/strategies/compositions/ensureImageVolume.ts
@@ -9,7 +9,7 @@ export default {
 
     let referencedImageIds;
     if (viewport) {
-      const referencedImageIds = viewport.getImageIds();
+      referencedImageIds = viewport.getImageIds();
       const isValidVolumeForSphere = csUtils.isValidVolume(referencedImageIds);
       if (!isValidVolumeForSphere) {
         throw new Error(

diff --git a/packages/tools/src/tools/segmentation/strategies/utils/getStrategyData.ts b/packages/tools/src/tools/segmentation/strategies/utils/getStrategyData.ts
@@ -172,9 +172,9 @@ function getStrategyData({
   strategy: unknown;
 }) {
   if (
-    ('volumeId' in operationData && operationData.volumeId !== undefined) ||
+    ('volumeId' in operationData && operationData.volumeId != null) ||
     ('referencedVolumeId' in operationData &&
-      operationData.referencedVolumeId !== undefined)
+      operationData.referencedVolumeId != null)
   ) {
     return getStrategyDataForVolumeViewport({ operationData });
   }