Skip to content

RFC for 4.x #1526

Open
Open
@sedghi

Description

@sedghi

Since Cornerstone3D 2.0 introduced significant changes with extensive migration guides, we chose to limit the scope of required modifications. Here's the list of changes - please share your preferences for version 3.0.

  • Move all viewports change set event to VIEWPORT_NEW_IMAGE_SET
  • Remove the edge for the viewports that are reported over and over here , here
  • rename the metadata and providers in Cornerstone to dcmjs style naming, so instead of sopInstanceUID we use SOPInstanceUID -> Maybe it goes to 4.0 since it is bigger
  • we need to get off the sliceIndex in the viewReference, and only rely on referencedImageId, and referencedImageURI
  • remove timePointIndex in favor of frameNumber in 4D (feat(4d): replace timepoint with dimensionGroupNumber for 4D handling with backward compatibility #1764)
  • ToolStyle is a mess, they require the user to grab first then merge then apply, we should follow the pattern in segmentationStyle
  • Move to standard for arrow annotate tools (fix(ArrowAnnotate): use svg marker to draw the arrow #1732)
  • Move away from volume Id to hashed image Ids -> make volume id optional

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions